Skip to content

Remove implicit focus from MCP typing helpers #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove implicit focus from MCP typing helpers #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
552f139
Initial plan
Copilot May 28, 2026
2ab9d69
fix: avoid implicit focus during typing
Copilot May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/mcp-server/src/driver/scripts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ export function buildTypeScript(selector: string, text: string, strategy?: strin
var element = window.__MCP__.resolveRef(selector, strategy);
if (!element) throw new Error('Element not found: ' + selector);

element.focus();

// Use native prototype setter to bypass React's value tracker
var proto = element.tagName === 'TEXTAREA'
? HTMLTextAreaElement.prototype
Expand Down
3 changes: 0 additions & 3 deletions packages/mcp-server/src/driver/scripts/keyboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ function typeText(params) {
throw new Error(`Element not found: ${selector}`);
}

// Focus the element
element.focus();

// Set the value
element.value = text;

Expand Down
5 changes: 4 additions & 1 deletion packages/mcp-server/tests/unit/webview-interactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,11 @@ describe('Webview Interactions Unit Tests', () => {

const result = await keyboard({ action: 'type', selectorOrKey: '#input', textOrModifiers: 'Hello World' });

const callArg = mockExecuteInWebview.mock.calls[0][0] as string;

expect(mockExecuteInWebview).toHaveBeenCalledOnce();
expect(mockExecuteInWebview).toHaveBeenCalledWith(expect.stringContaining('__MCP__'), undefined, undefined);
expect(callArg).toContain('__MCP__');
expect(callArg).not.toContain('.focus(');
expect(result).toContain('Typed');
});

Expand Down