Skip to content

Upgraded to SnakeYAML 1.10#2

Closed
atrus6 wants to merge 5 commits into
hyphanet:masterfrom
atrus6:master
Closed

Upgraded to SnakeYAML 1.10#2
atrus6 wants to merge 5 commits into
hyphanet:masterfrom
atrus6:master

Conversation

@atrus6

@atrus6 atrus6 commented May 22, 2012

Copy link
Copy Markdown

No description provided.

@infinity0

Copy link
Copy Markdown

thanks for the patch! it looks pretty straightforward, I will get around to it soon.

@Juiceman

Copy link
Copy Markdown
Contributor

I'll award the gun.io bounty as soon as infinity0 says it's working. Thanks Tim!

@Juiceman

Copy link
Copy Markdown
Contributor

@infinity0 - any updates on this?

@infinity0

Copy link
Copy Markdown

Sorry, I totally forgot about this. Yes, this looks good, but please fix the inconsistent spacing you've added to build.xml. I can do this by myself when I get some free time, but in that case I will be forced to overwrite your commits (rather than the "automatic merge" option github gives me) and you will need to hard-reset your repo to the new HEAD. (If you don't understand what I just said you need to learn more git.)

@infinity0

Copy link
Copy Markdown

Hi, did you get around to this? I've forgotten the context of this request and the master repo has since moved on from this.

@Juiceman

Juiceman commented Jul 8, 2013

Copy link
Copy Markdown
Contributor

I did not. I will find the repo for you if i still have it on github,
otherwise it will be weeks before I get my computer back.

Sent from my wireless phone.
On Jul 8, 2013 3:25 PM, "Ximin Luo" notifications@github.com wrote:

Hi, did you get around to this? I've forgotten the context of this request
and the master repo has since moved on from this.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-20629682
.

@Thynix

Thynix commented Oct 25, 2014

Copy link
Copy Markdown
Contributor

I take it this is still worthwhile in principle? This no longer merges cleanly, and SnakeYAML is at version 1.14 now.

@Juiceman

Copy link
Copy Markdown
Contributor

On Oct 25, 2014 11:37 AM, "Steve Dougherty" notifications@github.com
wrote:

I take it this is still worthwhile in principle? This no longer merges
cleanly, and SnakeYAML is at version 1.14 now.

I think it would be worthwhile, but I don't know enough about the code to
fix it myself.


Reply to this email directly or view it on GitHub.

@ArneBab

ArneBab commented May 23, 2016

Copy link
Copy Markdown
Contributor

@infinity0 this looks useful, but currently it doesn’t merge. Can you take it up again so we can merge and release it?

@ArneBab

ArneBab commented Feb 25, 2017

Copy link
Copy Markdown
Contributor

@infinity0 could you have another look? (I am now in a position where I can release soon)

@infinity0

Copy link
Copy Markdown

Hey, I'm sorry but my attention is elsewhere these days and I won't be able to complete this. Feel free to take it over completely.

@ArneBab ArneBab self-requested a review March 11, 2017 22:48
@desyncr

desyncr commented Jul 26, 2020

Copy link
Copy Markdown
Collaborator

@ArneBab Latest release is 1.26. Can the PR be upgraded to the latest release? I'm up for it.

@ArneBab

ArneBab commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

Sounds good.

@desyncr

desyncr commented Jul 28, 2020

Copy link
Copy Markdown
Collaborator

There's work already done at: https://github.com/redwerk/plugin-Library/tree/v37-dw-rw3

This PR should be closed.

@ArneBab

ArneBab commented Jul 28, 2020

Copy link
Copy Markdown
Contributor

Can you open another one for the new version?

@desyncr

desyncr commented Jul 29, 2020

Copy link
Copy Markdown
Collaborator

Can you open another one for the new version?

Do you mean to implement the upgrade on another PR? Would not that cause a merge conflict the redwerk's work?

@ArneBab

ArneBab commented Jul 29, 2020

Copy link
Copy Markdown
Contributor

I mean to just close this in favor of #15 which pulls in all the changes aggregated at redwerk.

@ArneBab ArneBab closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants