Feature jacobians - #4
Conversation
… to mimimize memory usage.
…ecies Air using MPP fluid model in implicit mode.
…xtures as monoatomic
There was a problem hiding this comment.
Pull Request Overview
This PR adds Jacobian/implicit capabilities for Mutation++ integration by updating the submodule reference and implementing new methods for computing chemistry and vibrational energy source term Jacobians. The changes enable implicit time stepping with Mutation++ fluid models in SU2.
- Updates Mutation++ submodule to a fork with Jacobian features
- Implements chemistry and vibrational energy source term Jacobian computation methods
- Removes the restriction preventing implicit time schemes with Mutation++ models
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| subprojects/Mutationpp | Updates submodule commit to include Jacobian features |
| meson_scripts/init.py | Updates Mutation++ repository URL and commit hash |
| SU2_CFD/src/numerics/NEMO/CNEMONumerics.cpp | Adds viscous Jacobian computation for 15-species case |
| SU2_CFD/src/fluid/CMutationTCLib.cpp | Implements Jacobian computation methods and removes implicit restriction |
| SU2_CFD/include/fluid/CMutationTCLib.hpp | Declares new Jacobian vectors and method signatures |
| Common/src/CConfig.cpp | Fixes gas model comparison and removes Mutation++ implicit restriction |
| .gitmodules | Updates Mutation++ submodule configuration to point to new fork |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| url = https://github.com/EvertBunschoten/MLPCpp.git | ||
| [submodule "subprojects/Mutationpp"] | ||
| path = subprojects/Mutationpp | ||
| url = git@github.com:hypersonic-lab/Mutationpp.git |
There was a problem hiding this comment.
Using SSH URL (git@github.com:) may cause issues for users without SSH keys configured. Consider using HTTPS URL (https://github.com/) for better accessibility.
| url = git@github.com:hypersonic-lab/Mutationpp.git | |
| url = https://github.com/hypersonic-lab/Mutationpp.git |
|
|
||
| monoatomic = GetGasModel() == "ARGON"; | ||
| // monoatomic = GetGasModel() == "ARGON"; //--original | ||
| monoatomic = StringToUpperCase(GetGasModel()) == "ARGON"; //--modified by RSCD |
There was a problem hiding this comment.
[nitpick] The comment format '//--modified by RSCD' doesn't follow standard commenting practices. Consider using a more descriptive comment explaining why the change was needed.
| monoatomic = StringToUpperCase(GetGasModel()) == "ARGON"; //--modified by RSCD | |
| monoatomic = StringToUpperCase(GetGasModel()) == "ARGON"; // Compare gas model to "ARGON" in a case-insensitive way for robustness. |
4529fee to
1734b40
Compare
1734b40 to
f3dd125
Compare
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Trying to add Raghava's contributions for the Mutationpp Jacobian/implicit capabilities.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.