Skip to content

Small fixes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luu-alex wants to merge 6 commits into from
Closed

Small fixes #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a16fd33
feat: update faucet
luu-alex Apr 3, 2026
9bf56c0
fix: update on feedback
luu-alex Apr 6, 2026
c7db809
fix: fix small bugs
luu-alex Apr 9, 2026
8c465bf
feat: update faucet
luu-alex Apr 3, 2026
2ff1d74
Merge branch 'prod' into small-fixes
luu-alex Apr 9, 2026
ef4ecb9
fix: update fee
luu-alex Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions src/components/trade/header/top-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { t } from "@lingui/core/macro";
import { Trans } from "@lingui/react/macro";
import { DownloadSimpleIcon, DropIcon, GearIcon, TrophyIcon } from "@phosphor-icons/react";
import { Link } from "@tanstack/react-router";
import { useConnection } from "wagmi";
import { Button } from "@/components/ui/button";
import { cn } from "@/lib/cn";
Expand All @@ -18,11 +17,6 @@ const isTestnet = import.meta.env.VITE_HYPERLIQUID_TESTNET === "true";
import { ThemeToggle } from "./theme-toggle";
import { UserMenu } from "./user-menu";

const SCOPE_NAV_ITEMS = [
{ scope: "all" as const, label: <Trans>All</Trans>, to: "/", activeClass: "text-text-950 font-medium" },
{ scope: "perp" as const, label: <Trans>Perp</Trans>, to: "/perp", activeClass: "text-scope-perp font-medium" },
] as const;

function getScopeAccentClass(scope: string): string {
switch (scope) {
case "perp":
Expand Down Expand Up @@ -62,21 +56,6 @@ export function TopNav() {
<span className="text-text-950"> Terminal</span>
</span>
</div>
<div className="h-4 w-px bg-border-200 hidden md:block" />
<nav className="hidden lg:flex items-center text-nav tracking-wide">
{SCOPE_NAV_ITEMS.map((item) => (
<Link
key={item.scope}
to={item.to}
className={cn(
"px-2.5 py-1.5 transition-colors duration-150",
scope === item.scope ? item.activeClass : "text-text-950 hover:text-text-600",
)}
>
{item.label}
</Link>
))}
</nav>
</div>

<div className="flex items-center gap-2">
Expand Down
2 changes: 1 addition & 1 deletion src/config/hyperliquid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ import type { BuilderConfig } from "@/lib/hyperliquid";
export const PROJECT_NAME = "HyperOdd";
export const DEFAULT_BUILDER_CONFIG: BuilderConfig = {
b: "0xe2E7BFE54DDfe5983807C187A57A939C33Eaeb2e", // builder
f: 1, // fee rate 0.001%
f: 1000, // fee rate 0.1%

@gemini-code-assist gemini-code-assist Bot Apr 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a mathematical inconsistency between the value change and the comment change. The value increased 1000x (from 1 to 1000), while the comment indicates a 100x increase in the fee rate (from 0.001% to 0.1%). If the intended fee is 0.1% and the previous scale was correct, the value should be 100. Please ensure the value aligns with the intended fee rate and the protocol's expected units.

};
4 changes: 2 additions & 2 deletions src/lib/chart/kline-styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function buildKlineStyles(candleType: CandleType): DeepPartial<Styles> {

const crosshairAxis = {
show: true,
line: { show: true, style: LineType.Dashed, dashedValue: [4, 2], size: 1, color: accent },
line: { show: true, style: LineType.Dashed, dashedValue: [4, 2], size: 1, color: scaleLineColor },
text: {
show: true,
color: overlayTextColor,
Expand All @@ -35,7 +35,7 @@ export function buildKlineStyles(candleType: CandleType): DeepPartial<Styles> {
paddingTop: 2,
paddingBottom: 2,
borderRadius: 2,
backgroundColor: accent,
backgroundColor: colorToHex(colors.surface),
borderSize: 0,
borderColor: "transparent",
},
Expand Down
5 changes: 2 additions & 3 deletions src/locales/ar/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ msgstr ""
#~ msgstr ""

#: src/components/trade/header/top-nav.tsx
msgid "All"
msgstr ""
#~ msgid "All"
#~ msgstr ""

#: src/components/trade/tradebox/margin-mode-dialog.tsx
msgid "All cross positions share the same cross margin as collateral. In the event of liquidation, your cross margin balance and any remaining open positions under assets in this mode may be forfeited."
Expand Down Expand Up @@ -1339,7 +1339,6 @@ msgstr "قيد الانتظار"
#~ msgid "perp"
#~ msgstr "دائم"

#: src/components/trade/header/top-nav.tsx
#: src/components/trade/positions/transfer-dialog.tsx
#: src/components/trade/positions/transfer-dialog.tsx
msgid "Perp"
Expand Down
5 changes: 2 additions & 3 deletions src/locales/en/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ msgstr "Advanced order types"
#~ msgstr "Agent verification failed"

#: src/components/trade/header/top-nav.tsx
msgid "All"
msgstr "All"
#~ msgid "All"
#~ msgstr "All"

#: src/components/trade/tradebox/margin-mode-dialog.tsx
msgid "All cross positions share the same cross margin as collateral. In the event of liquidation, your cross margin balance and any remaining open positions under assets in this mode may be forfeited."
Expand Down Expand Up @@ -1348,7 +1348,6 @@ msgstr "pending"
#~ msgid "perp"
#~ msgstr "perp"

#: src/components/trade/header/top-nav.tsx
#: src/components/trade/positions/transfer-dialog.tsx
#: src/components/trade/positions/transfer-dialog.tsx
msgid "Perp"
Expand Down
5 changes: 2 additions & 3 deletions src/locales/es/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ msgstr ""
#~ msgstr ""

#: src/components/trade/header/top-nav.tsx
msgid "All"
msgstr ""
#~ msgid "All"
#~ msgstr ""

#: src/components/trade/tradebox/margin-mode-dialog.tsx
msgid "All cross positions share the same cross margin as collateral. In the event of liquidation, your cross margin balance and any remaining open positions under assets in this mode may be forfeited."
Expand Down Expand Up @@ -1339,7 +1339,6 @@ msgstr "pendiente"
#~ msgid "perp"
#~ msgstr "perp"

#: src/components/trade/header/top-nav.tsx
#: src/components/trade/positions/transfer-dialog.tsx
#: src/components/trade/positions/transfer-dialog.tsx
msgid "Perp"
Expand Down
5 changes: 2 additions & 3 deletions src/locales/fr/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ msgstr ""
#~ msgstr ""

#: src/components/trade/header/top-nav.tsx
msgid "All"
msgstr ""
#~ msgid "All"
#~ msgstr ""

#: src/components/trade/tradebox/margin-mode-dialog.tsx
msgid "All cross positions share the same cross margin as collateral. In the event of liquidation, your cross margin balance and any remaining open positions under assets in this mode may be forfeited."
Expand Down Expand Up @@ -1339,7 +1339,6 @@ msgstr "en attente"
#~ msgid "perp"
#~ msgstr "perp"

#: src/components/trade/header/top-nav.tsx
#: src/components/trade/positions/transfer-dialog.tsx
#: src/components/trade/positions/transfer-dialog.tsx
msgid "Perp"
Expand Down
5 changes: 2 additions & 3 deletions src/locales/hi/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ msgstr ""
#~ msgstr ""

#: src/components/trade/header/top-nav.tsx
msgid "All"
msgstr ""
#~ msgid "All"
#~ msgstr ""

#: src/components/trade/tradebox/margin-mode-dialog.tsx
msgid "All cross positions share the same cross margin as collateral. In the event of liquidation, your cross margin balance and any remaining open positions under assets in this mode may be forfeited."
Expand Down Expand Up @@ -1339,7 +1339,6 @@ msgstr "लंबित"
#~ msgid "perp"
#~ msgstr "परप"

#: src/components/trade/header/top-nav.tsx
#: src/components/trade/positions/transfer-dialog.tsx
#: src/components/trade/positions/transfer-dialog.tsx
msgid "Perp"
Expand Down
5 changes: 2 additions & 3 deletions src/locales/zh/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ msgstr ""
#~ msgstr ""

#: src/components/trade/header/top-nav.tsx
msgid "All"
msgstr ""
#~ msgid "All"
#~ msgstr ""

#: src/components/trade/tradebox/margin-mode-dialog.tsx
msgid "All cross positions share the same cross margin as collateral. In the event of liquidation, your cross margin balance and any remaining open positions under assets in this mode may be forfeited."
Expand Down Expand Up @@ -1339,7 +1339,6 @@ msgstr "待处理"
#~ msgid "perp"
#~ msgstr "永续"

#: src/components/trade/header/top-nav.tsx
#: src/components/trade/positions/transfer-dialog.tsx
#: src/components/trade/positions/transfer-dialog.tsx
msgid "Perp"
Expand Down
14 changes: 13 additions & 1 deletion src/routes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { createFileRoute } from "@tanstack/react-router";
import { useEffect } from "react";
import { TradeTerminalPage } from "@/components/trade/trade-terminal-page";
import { buildPageHead } from "@/lib/seo";
import { useMarketActions } from "@/stores/use-market-store";

export const Route = createFileRoute("/")({
ssr: false,
Expand All @@ -12,5 +14,15 @@ export const Route = createFileRoute("/")({
path: "/",
keywords: ["trade", "orderbook", "chart", "perpetuals", "spot"],
}),
component: TradeTerminalPage,
component: IndexPage,
});

function IndexPage() {
const { setSelectedMarket } = useMarketActions();

useEffect(() => {
setSelectedMarket("all", "VOLX-USDH");
}, [setSelectedMarket]);
Comment on lines +23 to +25

@gemini-code-assist gemini-code-assist Bot Apr 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This useEffect unconditionally resets the selected market to VOLX-USDH whenever the index page is mounted. This overrides the user's persisted market selection from useMarketStore, which can lead to a confusing user experience when navigating back to the home route. Consider implementing logic to only set a default if no market is currently selected or if this is the intended behavior for the landing page.


return <TradeTerminalPage />;
}
Loading