fix: prod deploy - #10
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures the project for deployment on Cloudflare Pages by updating the Nitro preset, adding necessary permissions, and removing the deprecated @tanstack/react-router-ssr-query integration. Additionally, a patch was applied to @tanstack/start-plugin-core to fix a recursive CSS resolution issue. Regarding the review feedback, it is recommended to revert the formatter change in .vscode/settings.json back to Biome to ensure consistency across all JSON files and avoid unnecessary formatting diffs.
| }, | ||
| "[json]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode" |
There was a problem hiding this comment.
The default formatter for JSON has been changed to Prettier, which is inconsistent with the project's use of Biome for other file types (like jsonc). This inconsistency is likely what caused the package.json file to be reformatted from tabs to spaces, creating a noisy diff. It is recommended to use Biome for JSON files as well to maintain consistency across the codebase.
| "editor.defaultFormatter": "esbenp.prettier-vscode" | |
| "editor.defaultFormatter": "biomejs.biome" |
1 participant
No description provided.