Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tools/fxconfig/internal/transaction/merge.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,15 @@ func validateTransactionsForMerge(txs []*applicationpb.Tx) error {
return fmt.Errorf("transaction %d: namespace count mismatch", i)
}

if len(tx.GetEndorsements()) != baseNsCount {
return fmt.Errorf(
"transaction %d: endorsements count (%d) does not match namespaces count (%d)",
i,
len(tx.GetEndorsements()),
baseNsCount,
)
}

for nsIdx := range baseTx.GetNamespaces() {
if !proto.Equal(baseTx.GetNamespaces()[nsIdx], txs[i].GetNamespaces()[nsIdx]) {
return fmt.Errorf("transaction %d: namespace %d content mismatch", i, nsIdx)
Expand Down
44 changes: 44 additions & 0 deletions tools/fxconfig/internal/transaction/merge_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,50 @@ func TestMerge_ErrorCases(t *testing.T) {
require.Contains(t, err.Error(), "requires at least one endorsement")
})

t.Run("endorsements count mismatch", func(t *testing.T) {
t.Parallel()

tx1 := &applicationpb.Tx{
Namespaces: []*applicationpb.TxNamespace{
{NsId: "ns1", NsVersion: 1},
},
Endorsements: []*applicationpb.Endorsements{
{
EndorsementsWithIdentity: []*applicationpb.EndorsementWithIdentity{
{Endorsement: []byte("sig-a1"), Identity: &msppb.Identity{MspId: "Org1MSP"}},
},
},
{
EndorsementsWithIdentity: []*applicationpb.EndorsementWithIdentity{
{Endorsement: []byte("sig-a2"), Identity: &msppb.Identity{MspId: "Org2MSP"}},
},
},
},
}
tx2 := &applicationpb.Tx{
Namespaces: []*applicationpb.TxNamespace{
{NsId: "ns1", NsVersion: 1},
},
Endorsements: []*applicationpb.Endorsements{
{
EndorsementsWithIdentity: []*applicationpb.EndorsementWithIdentity{
{Endorsement: []byte("sig-b1"), Identity: &msppb.Identity{MspId: "Org3MSP"}},
},
},
{
EndorsementsWithIdentity: []*applicationpb.EndorsementWithIdentity{
{Endorsement: []byte("sig-b2"), Identity: &msppb.Identity{MspId: "Org4MSP"}},
},
},
},
}

result, err := Merge([]*applicationpb.Tx{tx1, tx2})
require.Error(t, err)
require.Nil(t, result)
require.Contains(t, err.Error(), "endorsements count")
})

t.Run("conflicting namespace writes", func(t *testing.T) {
t.Parallel()

Expand Down