Fix a number of bugs/corner cases#261
Merged
Merged
Conversation
… stale unique cell ID which made the off-wall check always pass
…er of exactly zero cannot produce an out-of-bounds index of 0
…walls contribute when they wrap to the same neighbour
…mplate and regenerate grid_io_1d.f90
… maps can be read
… against xmax and zmax
…o it no longer always returns zero
… are not accumulated across dust types
…rom division by zero cell volume
…without convergence checking do not write an undefined value
…d of a non-blocking send of an expression temporary
…nstead of only the first n1 characters
… zero instead of silently producing NaNs
…ensity inside the centrifugal radius
…ieXDust NaN repair works instead of raising a bounds error
…eton in Source.get_spectrum
… integrating up to the last tabulated x in the four subset integrators
…level index in the per-grid path
…nexistent refined attribute and copy bounds when cloning geometry
…ng integer division for np.split
…nd always failed on Python 3
…tribute written by _write_monochromatic
…roup_00001 subgroup where it is written
…ding the HDF5 group name
…ring as get_quantities
… enabling convergence checking
….from_hdf5_group so nu0 survives the HDF5 round trip
…not get backslash separators on Windows
astrofrog
marked this pull request as ready for review
July 25, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I asked Claude Fable to review the whole codebase and check for any issues, and these are ones it identified and which definitely need fixing. I checked each and every fix here and I only included ones here which are definitely correct.