Make changes to enable add_attributes to operate more qiuckly - #288
Merged
Conversation
knoxsp
commented
Jun 23, 2026
knoxsp
left a comment
knoxsp
left a comment
Contributor
Author
There was a problem hiding this comment.
Three findings from code review — two correctness issues and one efficiency concern.
…nsertions more deterministic. 2. bypass check_can_add_attribute for greater speed. and 3. use a lookup table to check for uniqueness instead of using a DB constraint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.