Skip to content

Fix STOR command reply message to prevent client truncation #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hxcan merged 1 commit into from
May 13, 2026
Merged

Fix STOR command reply message to prevent client truncation #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions builtinftp/src/main/java/com/stupidbeauty/ftpserver/lib/ControlConnectHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ public class ControlConnectHandler implements DataServerManagerInterface
private DocumentFile writingFile; //!< 当前正在写入的文件。
private ParcelFileDescriptor pfd = null;
private FileOutputStream fileOutputStream = null;
private long totalWritten = 0; // 用于速度统计
private long lastLogTime = 0; // 用于速度统计
private long totalWritten = 0; //! 用于速度统计
private long lastLogTime = 0; //! 用于速度统计

private DocumentFile renamingFile; //!< The file being renamed.
private boolean isUploading=false; //!< 是否正在上传。陈欣
Expand Down Expand Up @@ -300,7 +300,7 @@ public void onConnectCompleted(Exception ex, final AsyncSocket socket)
logDebug("CONNECT_TO_CLIENT", "port=" + port); // [DEBUG]
} // private void connectToClientDataPort()


/**
* 打开指向客户端特定端口的连接。
*/
Expand Down Expand Up @@ -572,7 +572,7 @@ private void processRetrCommand(String data51)
*/
private void processStorCommand(String data51)
{
String replyString="150 "; // 回复内容。
String replyString="150 Opening data connection for STOR"; // 回复内容。

boolean storStartResult = startStor(data51, currentWorkingDirectory); // Start stor process.

Expand Down Expand Up @@ -925,6 +925,7 @@ private void processRntoCommand(String data51)
} // else // rename failed



// Chen xin. remove cache DocumentFile.

// Chen xin
Expand Down Expand Up @@ -1310,7 +1311,7 @@ else if (command.equalsIgnoreCase("MKD")) // 创建目录

Log.d(TAG, "reply string: " + replyString); //Debug.

binaryStringSender.sendStringInBinaryMode(replyString); // 回复。
binaryStringSender.sendStringInBinaryMode(replyString); // 发送。
} //else if (command.equals("EPSV")) // Extended passive mode.
} // private void processCommand(String command, String content)

Expand Down Expand Up @@ -1467,7 +1468,7 @@ private void requestAndroidDataPermission()
// try
// {
// Uri uri = Uri.parse("content://com.android.externalstorage.documents/document/primary%3AAndroid%2Fdata");

File androidDataFile=new File(Constants.FilePath.AndroidData); // Get the file object.

Uri uri = Uri.parse("content://com.android.externalstorage.documents/document/primary%3AAndroid%2Fdata");
Expand Down Expand Up @@ -1967,4 +1968,4 @@ private void logDebug(String tag, String message) {
Log.e(TAG, "[DEBUG] Failed: " + e.getMessage());
}
}
}
}
Loading