ub->gm传递l2_cache_ctl参数#920
Conversation
Codex Review该评论由 review 机器人自动更新。
SummaryReview failed at stage Findings未生成结构化 findings,因为 review 过程提前失败。 Log Tail |
There was a problem hiding this comment.
Code Review
This pull request introduces support for GM store-side L2 cache control in the pto.mte_ub_gm and pto.copy_ubuf_to_gm operations by replacing a previously reserved field with the l2_cache_ctl parameter. The changes include updates to the dialect definition, parser, printer, verifier (ensuring constant values fit in the [0, 15] range), LLVM emitters, and documentation. Existing tests and examples have been updated to include the new parameter, and a new test file has been added to verify its roundtrip and expansion. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
7d57f84 to
f8686b4
Compare
TODO:
增加兼容性,保持默认l2_cache_ctl=0,显式传值时则使用显式值,ci中