fix(Select): ensure Select.Value labels persist after select is closed in type="multiple"#2066
Open
ieedan wants to merge 2 commits into
Open
fix(Select): ensure Select.Value labels persist after select is closed in type="multiple"#2066ieedan wants to merge 2 commits into
Select.Value labels persist after select is closed in type="multiple"#2066ieedan wants to merge 2 commits into
Conversation
…sed in `type="multiple"`
🦋 Changeset detectedLatest commit: 3344198 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
…bel persistence in single select mode
huntabyte
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2062
This was something I simply wasn't thinking about in #2026 when items unmount they take their visual labels with them. So if you haven't provided the items prop to
Select.Rootas soon as the menu unmounts the items you will no longer have labels.This can of course be fixed by just providing the
itemsprop but it would be nice if it was a little more robust to avoid issues like #2062