Fix: Make m230401_174208_add_allow_jwt_auth migration resilient when module is not bootstrapped#242
Merged
Merged
Conversation
…module is not bootstrapped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Yii::$app->getModule('rest')->settingscalls with directsettingtable queries — the module may not be registered duringmigrate/up(core#[WithoutModuleAutoload]skips third-party module bootstrap)upsert()for writing settings, making the migration naturally idempotentTest plan
migrate/upon an instance where rest was previously installed — migration should complete without errorsmigrate/upa second time — upsert makes it idempotent, should skip cleanlyenableJwtAuthis set correctly based on whetherjwtKeywas previously configured