Fix: Message entries overflow horizontally on iOS Safari#504
Merged
Conversation
Contributor
Author
|
@luke- PR tested on Chrome desktop, mobile and Safari iOS |
Contributor
|
@marc-farre Idea regarding the failing test? |
Contributor
Author
|
@luke- the test fails when this button is clicked: But when testing locally with And when testing manually, it works fine. GitHub codeception output looks correct (it's what we should see after clicking the button):
I re-runned the failing job twice, and always the same error. Maybe Yura would have an idea? |
Contributor
|
@marc-farre Thanks, I've fixed it. Tests are green now: https://github.com/humhub/mail/actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Before this PR, on iOS Safari, the message entries on the right were too much at the right (about 20px).
Because of that, an horizontal scroll was possible.