fix(tui): preserve IME input in iTerm2 - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hmzruns directly in iTerm2, restoring Chinese and other IME-composed inputTEXTUAL_DISABLE_KITTY_KEYchoice and configure Textual before its first importRoot cause
Textual enables Kitty's report-all-keys and associated-text modes. iTerm2's direct handling of that combination loses IME-composed text before it reaches the
TextArea. tmux changes the terminal protocol boundary and does not reproduce the failure.This uses Textual's supported compatibility switch rather than modifying its input driver or handling composed text inside the editor.
Test plan
uv run pre-commit run --all-filesuv run pytest(1096 passed, 58 skipped)