Skip to content

ty fix #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugoh merged 3 commits into from
Jul 26, 2026
Merged

ty fix #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fea8f25
chore: mark package as Beta, drop redundant license classifier
hugoh Jul 26, 2026
5a8d3e0
chore(deps): upgrade
hugoh Jul 26, 2026
89293c4
fix(atv): build ProtocolSettings directly to satisfy type checker
hugoh Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,10 @@ authors = [
{ name = "Hugo Haas" },
]
classifiers = [
"Development Status :: 3 - Alpha",
"Development Status :: 4 - Beta",
"Environment :: Console",
"Environment :: Web Environment",
"Intended Audience :: End Users/Desktop",
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.12",
"Topic :: Home Automation",
Expand Down
22 changes: 9 additions & 13 deletions src/pyatv_http/atv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,39 +26,35 @@ class DeviceUnreachableError(Exception):
"""Raised when the Apple TV cannot be found on the network."""


def _protocol_settings(
device: DeviceConfig,
) -> dict[
str, AirPlaySettings | CompanionSettings | DmapSettings | MrpSettings | RaopSettings
]:
def _protocol_settings(device: DeviceConfig) -> ProtocolSettings:
empty = ProtocolCredential()
airplay = device.protocols.get("airplay", empty)
companion = device.protocols.get("companion", empty)
dmap = device.protocols.get("dmap", empty)
mrp = device.protocols.get("mrp", empty)
raop = device.protocols.get("raop", empty)

return {
"airplay": AirPlaySettings(
return ProtocolSettings(
airplay=AirPlaySettings(
identifier=airplay.identifier,
credentials=airplay.credentials,
password=airplay.password,
),
"companion": CompanionSettings(
companion=CompanionSettings(
identifier=companion.identifier, credentials=companion.credentials
),
"dmap": DmapSettings(identifier=dmap.identifier, credentials=dmap.credentials),
"mrp": MrpSettings(identifier=mrp.identifier, credentials=mrp.credentials),
"raop": RaopSettings(
dmap=DmapSettings(identifier=dmap.identifier, credentials=dmap.credentials),
mrp=MrpSettings(identifier=mrp.identifier, credentials=mrp.credentials),
raop=RaopSettings(
identifier=raop.identifier,
credentials=raop.credentials,
password=raop.password,
),
}
)


def _build_storage(device: DeviceConfig) -> MemoryStorage:
settings = Settings(protocols=ProtocolSettings(**_protocol_settings(device)))
settings = Settings(protocols=_protocol_settings(device))
storage = MemoryStorage()
storage.storage_model = StorageModel(version=MODEL_VERSION, devices=[settings])
return storage
Expand Down
Loading