Support linear Resize in candle-onnx#3671
Open
jesco-absolut wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3153.
This adds
linearmode support for the 4DResizeoperator incandle-onnx'ssimple_evalpath.nearestpath and its current constraints unchangedmode="linear"+coordinate_transformation_mode="half_pixel"toTensor::upsample_bilinear2d(..., align_corners=false)mode="linear"+coordinate_transformation_mode="align_corners"toTensor::upsample_bilinear2d(..., align_corners=true)linearcoordinate transformation modes explicitlyTests
Added focused ONNX op tests in
candle-onnx/tests/ops.rsfor:Resizewithmode="linear"andcoordinate_transformation_mode="half_pixel"Resizewithmode="linear"andcoordinate_transformation_mode="align_corners"Before the source change, the
half_pixelregression test failed with:After the change, the focused resize tests pass.
Validation
Passed:
Notes:
cargo test --manifest-path candle-onnx/Cargo.tomlcurrently fails in unrelatedtest_gelu_operationdue exact float equality (0.8413447vs0.8413448).cargo clippy --manifest-path candle-onnx/Cargo.toml --tests -- -D warningsis currently blocked by pre-existing generated-code/test lints incandle-onnx, not by this patch.Blast radius
This only changes the
Resizearm incandle-onnx/src/eval.rs.Existing
nearestbehavior remains constrained to the previous supported path (nearest_mode="floor",coordinate_transformation_mode="asymmetric"). The new behavior is limited to 4D linear resize using Candle's existing bilinear resize primitive.