[pull] dev from apache:dev - #159
Merged
Merged
Conversation
Co-authored-by: zengyi <zengyi@chinatelecom.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )
Greptile Summary
The PR introduces a standard logical metadata contract for Knowledge Sync document and chunk identity and enables explicit projection through the existing Metadata transform.
Confidence Score: 5/5
The PR appears safe to merge with no actionable changed-code defects identified.
The new metadata keys are accepted only by the Metadata transform, schema-declared fields are validated before projection, row options are preserved through the transform path, and the refactor retains existing computed common-metadata behavior.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Upstream producer] -->|declares logical keys| B[CatalogTable metadata schema] A -->|writes values| C[SeaTunnelRow options] B --> D[Metadata transform validation] C --> E[Metadata transform projection] D --> E E --> F[Canonical physical columns]Reviews (1): Last reviewed commit: "[Feature][API] Define Knowledge Sync met..." | Re-trigger Greptile