fix: gate npm publish on CI success and release-version bump - #251
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s release/publish pipeline by switching npm publishing to run only after successful main CI completion, adding a version-bump gate to avoid duplicate publishes, and aligning publishing documentation with the updated release flow.
Changes:
- Switch
.github/workflows/publish.ymlto trigger fromworkflow_runof the main test workflow and add a release/version gate plus prerelease dist-tag mapping. - Refresh dependencies and bump the package version to
0.0.16in the lockfile. - Update publishing documentation to reflect CI-gated publishing and prerelease channel tagging.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
package-lock.json |
Bumps package version and updates dependency lock to match new release/tooling versions. |
docs/development/publishing.md |
Documents the new “CI-first on main” publish flow and dist-tag behavior. |
.github/workflows/publish.yml |
Reworks publishing trigger/gating to run after successful main CI and auto-select dist-tags for prereleases. |
Suppressed comments (1)
docs/development/publishing.md:155
- The troubleshooting checklist implies a publish can happen with only a package-lock.json version bump, but the publish gate compares the version from package.json. This item should mention bumping package.json (and keeping the lockfile in sync) to match the workflow behavior.
- Was the `main` branch push a deliberate version bump in `package.json` or `package-lock.json`?
- Did the required CI checks pass on the merge commit before the publish workflow started?
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation