Skip to content

refactor: remove Qt5Compat dependency #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hthienloc merged 1 commit into from
Aug 20, 2026
Merged

refactor: remove Qt5Compat dependency #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ Screenshot annotation plugin for DankMaterialShell.
| **img2pdf** | PDF export |
| **tesseract** | OCR text scanner |
| **zbar** (`zbarimg`) | QR scanner |
| **Qt5Compat GraphicalEffects** (`qt6-qt5compat`) | Floating images |
| **Rust screenshot backend** | Installed separately when the New Backend is selected |
| **curl** and **sha256sum** | Verify and install the Rust backend release asset |

Expand Down
23 changes: 13 additions & 10 deletions components/floating/FloatWindow.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import QtQuick
import QtQuick.Controls
import QtQuick.Layouts
import Qt5Compat.GraphicalEffects as GE
import QtQuick.Effects
import Quickshell
import Quickshell.Wayland
import qs.Common
Expand Down Expand Up @@ -382,14 +381,9 @@ PanelWindow {
visible: opacity > 0

layer.enabled: true
layer.effect: GE.OpacityMask {
maskSource: Rectangle {
width: img.width
height: img.height
radius: Math.max(0, Theme.cornerRadius - window.borderWidth)
visible: false
antialiasing: true
}
layer.effect: MultiEffect {
maskEnabled: true
maskSource: imgMask
}

onStatusChanged: {
Expand All @@ -404,6 +398,15 @@ PanelWindow {
}
}

Rectangle {
id: imgMask
anchors.fill: img
radius: Math.max(0, Theme.cornerRadius - window.borderWidth)
visible: false
antialiasing: true
layer.enabled: true
}
Comment thread
sourcery-ai[bot] marked this conversation as resolved.

// Minimized Icon
DankIcon {
id: cloudIcon
Expand Down