Skip to content

feat(editor): add option to open editor above fullscreen windows - #216

Merged
hthienloc merged 3 commits into
hthienloc:mainfrom
wongcallum:feat/editor-overlay-layer
Aug 8, 2026
Merged

feat(editor): add option to open editor above fullscreen windows#216
hthienloc merged 3 commits into
hthienloc:mainfrom
wongcallum:feat/editor-overlay-layer

Conversation

@wongcallum

@wongcallum wongcallum commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds an Open Above Fullscreen Windows toggle to the Editor settings tab (enabled by default) that puts the screenshot editor on the Overlay layer instead of the Top layer, so it is no longer hidden behind fullscreen windows.

Use Case

Previously, capturing a screenshot while a window is fullscreen opens an editor behind the fullscreen window. The user has to un-fullscreen the window or switch workspaces to get to it.

Changes

  • CaptureConfig.qml: new modalOverlayLayer property reading the modalOverlayLayer setting, defaulting to true
  • QuickCaptureModal.qml: binds DankModal.useOverlayLayer to modalOverlayLayer
  • QuickCaptureDaemon.qml: same flag on the Recent Edits history carousel modal
  • QuickCaptureSettings.qml: ToggleSettingPlus at the end of the Editor card and reset logic

Related Issues

Closes #215.

Testing

NixOS 26.11, niri 26.04, DMS 1.6-beta+date=2026-08-02_400a18a, Quick Capture 4.0.5

I tested it by checking niri msg layers when opening the editor, and by opening the editor while playing osu!, which previously displayed behind the game window.

Screenshots / Screen Recordings

Before:

2026-08-08.22-32-49.mp4

After:

2026-08-08.22-31-16.mp4

Checklist

  • I have tested these changes on my setup
  • I have updated the documentation (README, IPC/settings docs) if needed
  • I have verified the plugin loads without errors

Summary by Sourcery

Add a configurable option for the screenshot editor to open above fullscreen windows and ensure related editor modals respect this setting.

New Features:

  • Introduce an Editor setting to toggle opening the screenshot editor above fullscreen windows, enabled by default.

Enhancements:

  • Wire the new overlay-layer setting through capture configuration and modal components so editor and recent-edits dialogs can render on the overlay layer.
  • Extend the Editor settings reset behavior to include the new overlay-layer option.

@sourcery-ai

sourcery-ai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a new editor setting to control whether editor modals use the overlay layer so they remain visible above fullscreen windows, wiring the setting through configuration and both modal components and integrating it with existing reset behavior in the Editor settings section.

Flow diagram for editor overlay layer setting propagation

flowchart LR
    modalOverlayLayerSetting[Editor setting modalOverlayLayer]
    pluginData[pluginData modalOverlayLayer]
    captureConfig[CaptureConfig.modalOverlayLayer]
    quickCaptureModal[QuickCaptureModal.useOverlayLayer]
    quickCaptureDaemon[QuickCaptureDaemon.useOverlayLayer]

    modalOverlayLayerSetting --> pluginData
    pluginData --> captureConfig
    captureConfig --> quickCaptureModal
    pluginData --> quickCaptureDaemon
Loading

File-Level Changes

Change Details Files
Introduce a configurable modal overlay layer setting for the editor and hook it into modal behavior.
  • Add a read-only boolean modalOverlayLayer property to the capture configuration that defaults to true unless explicitly set to false in plugin data.
  • Bind the main editor modal’s useOverlayLayer flag to the capture configuration’s modalOverlayLayer property.
  • Set the recent edits history carousel modal’s useOverlayLayer flag based on the modalOverlayLayer plugin data value, defaulting to true.
CaptureConfig.qml
QuickCaptureModal.qml
QuickCaptureDaemon.qml
Expose the overlay layer behavior as a user-facing toggle in the Editor settings and integrate it with the section reset logic.
  • Add a ToggleSettingPlus for the Open Above Fullscreen Windows option in the Editor settings card, with a default value of true and descriptive label/description.
  • Include the new modalOverlayLayer setting in the Editor section’s showReset condition so the reset icon appears when it is dirty.
  • Reset modalOverlayLayer to its default value when the Editor section reset action is triggered.
QuickCaptureSettings.qml

Assessment against linked issues

Issue Objective Addressed Explanation
#215 Add an editor setting to control whether the screenshot editor uses the overlay modal layer, with the option enabled by default.
#215 Wire the screenshot editor (QuickCaptureModal) to use the overlay layer based on the new setting so it opens above fullscreen windows.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The defaulting logic for modalOverlayLayer is duplicated (CaptureConfig.qml vs QuickCaptureDaemon.qml); consider centralizing this in one place to avoid divergence if the default behavior ever changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The defaulting logic for `modalOverlayLayer` is duplicated (`CaptureConfig.qml` vs `QuickCaptureDaemon.qml`); consider centralizing this in one place to avoid divergence if the default behavior ever changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hthienloc
hthienloc merged commit efc30a1 into hthienloc:main Aug 8, 2026
1 check passed
@hthienloc

Copy link
Copy Markdown
Owner

Thanks for your PR. I removed the option because I couldn’t identify a practical use case for disabling the overlay layer. Since users explicitly open the editor, it should always appear above fullscreen windows.

@wongcallum

Copy link
Copy Markdown
Contributor Author

Gotcha thanks :)

@wongcallum
wongcallum deleted the feat/editor-overlay-layer branch August 8, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Open screenshot editor above fullscreen windows

2 participants