feat(editor): add option to open editor above fullscreen windows - #216
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new editor setting to control whether editor modals use the overlay layer so they remain visible above fullscreen windows, wiring the setting through configuration and both modal components and integrating it with existing reset behavior in the Editor settings section. Flow diagram for editor overlay layer setting propagationflowchart LR
modalOverlayLayerSetting[Editor setting modalOverlayLayer]
pluginData[pluginData modalOverlayLayer]
captureConfig[CaptureConfig.modalOverlayLayer]
quickCaptureModal[QuickCaptureModal.useOverlayLayer]
quickCaptureDaemon[QuickCaptureDaemon.useOverlayLayer]
modalOverlayLayerSetting --> pluginData
pluginData --> captureConfig
captureConfig --> quickCaptureModal
pluginData --> quickCaptureDaemon
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The defaulting logic for
modalOverlayLayeris duplicated (CaptureConfig.qmlvsQuickCaptureDaemon.qml); consider centralizing this in one place to avoid divergence if the default behavior ever changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The defaulting logic for `modalOverlayLayer` is duplicated (`CaptureConfig.qml` vs `QuickCaptureDaemon.qml`); consider centralizing this in one place to avoid divergence if the default behavior ever changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Owner
|
Thanks for your PR. I removed the option because I couldn’t identify a practical use case for disabling the overlay layer. Since users explicitly open the editor, it should always appear above fullscreen windows. |
Contributor
Author
|
Gotcha thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an Open Above Fullscreen Windows toggle to the Editor settings tab (enabled by default) that puts the screenshot editor on the Overlay layer instead of the Top layer, so it is no longer hidden behind fullscreen windows.
Use Case
Previously, capturing a screenshot while a window is fullscreen opens an editor behind the fullscreen window. The user has to un-fullscreen the window or switch workspaces to get to it.
Changes
Related Issues
Closes #215.
Testing
NixOS 26.11, niri 26.04, DMS 1.6-beta+date=2026-08-02_400a18a, Quick Capture 4.0.5
I tested it by checking
niri msg layerswhen opening the editor, and by opening the editor while playing osu!, which previously displayed behind the game window.Screenshots / Screen Recordings
Before:
2026-08-08.22-32-49.mp4
After:
2026-08-08.22-31-16.mp4
Checklist
Summary by Sourcery
Add a configurable option for the screenshot editor to open above fullscreen windows and ensure related editor modals respect this setting.
New Features:
Enhancements: