Skip to content

Door NFRC values#280

Draft
shorowit wants to merge 2 commits into
masterfrom
door_nfrc
Draft

Door NFRC values#280
shorowit wants to merge 2 commits into
masterfrom
door_nfrc

Conversation

@shorowit

@shorowit shorowit commented Jul 13, 2021

Copy link
Copy Markdown
Contributor

Closes #279.

  1. Adds UFactor and SHGC elements for doors.
  2. Adds DoorDescription element. Choices based on NFRC are: "embossed", "flush", "full lite", "1/2 - lite", "1/4 - lite", "3/4 - lite", "raised panel", and "other".
  3. Clarifies that UFactor/RValue elements (for doors, windows, and skylights) include air films.

Should we mark RValue as deprecated, so that UFactor is used instead going forward?

@shorowit

shorowit commented Jul 21, 2021

Copy link
Copy Markdown
Contributor Author

Copy over other elements like Overhangs (or use WindowInfo group of elements).
Note that the WindowType proposal allows a door choice.
Some support for marking RValue as deprecated.

@shorowit

Copy link
Copy Markdown
Contributor Author

It would be hard to further improve this without making breaking changes. I suggest we defer this until v4.0 and do this correctly.

@shorowit shorowit added this to the v4.0 milestone Jul 21, 2021
@shorowit shorowit marked this pull request as draft July 21, 2021 17:31
@nmerket

nmerket commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

@shorowit shorowit removed this from the v4.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow NFRC values for doors

3 participants