Draft Version for asyncio - #38
Draft
rad-pat wants to merge 8 commits into
Draft
Conversation
Collaborator
|
Hi @rad-pat. I think this is amazing. Will take some time to review but I definitely will |
Contributor
Author
Thanks. Like I said, it is just a draft, hopefully mostly working, but with no tests. I'm happy to try to keep it updated if you have comments in the future. |
Contributor
Author
|
Some more updates/fixes added. Including:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had the need to run this as a websocket STOMP server using starlette and asyncio so I amended some of the classes to work for my use case (a STOMP websocket wrapper to Redis Pub/Sub). I have tried to run through all the remaining classes, updating for asyncio and eventually creating a socket server which runs, but it is largely untested. This may serve as a starter for someone else who finds it and wants to take it further.