Skip to content

Draft Version for asyncio - #38

Draft
rad-pat wants to merge 8 commits into
hozn:masterfrom
rad-pat:asyncio
Draft

Draft Version for asyncio#38
rad-pat wants to merge 8 commits into
hozn:masterfrom
rad-pat:asyncio

Conversation

@rad-pat

@rad-pat rad-pat commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

I had the need to run this as a websocket STOMP server using starlette and asyncio so I amended some of the classes to work for my use case (a STOMP websocket wrapper to Redis Pub/Sub). I have tried to run through all the remaining classes, updating for asyncio and eventually creating a socket server which runs, but it is largely untested. This may serve as a starter for someone else who finds it and wants to take it further.

@ZhukovAlexander

Copy link
Copy Markdown
Collaborator

Hi @rad-pat. I think this is amazing. Will take some time to review but I definitely will

@rad-pat

rad-pat commented Jul 25, 2023

Copy link
Copy Markdown
Contributor Author

Hi @rad-pat. I think this is amazing. Will take some time to review but I definitely will

Thanks. Like I said, it is just a draft, hopefully mostly working, but with no tests. I'm happy to try to keep it updated if you have comments in the future.

@rad-pat

rad-pat commented Jul 27, 2023

Copy link
Copy Markdown
Contributor Author

Some more updates/fixes added. Including:

  1. If a subscription is made without an id header, the subscription should not be included on any MESSAGE (STOMP10)
  2. If a subscription is made with an id header, it should be possible to unsubscribe by id alone (ALL VERSIONS, but mandatory for STOMP 11/12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants