Skip to content

Unknown fix #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vgeof-hove wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Unknown fix #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c763ea2
fix new_cost smaller than 0
Nov 12, 2024
33de5a8
fix in timedistancematrix.cc
Nov 13, 2024
b5269b9
Fix Format
vgeof-hove Nov 6, 2025
d42791a
Merge pull request #24 from hove-io/reapply_commits
vgeof-hove Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/thor/timedistancebssmatrix.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ bool TimeDistanceBSSMatrix::UpdateDestinations(
// Subtract the partial remaining cost and distance along the edge.
float remainder = dest_edge->second;
Cost newcost = pred.cost() - (pedestrian_costing_->EdgeCost(edge, tile) * remainder);
if (newcost.cost < dest.best_cost.cost) {
if (newcost.cost > 0 && newcost.cost < dest.best_cost.cost) {
dest.best_cost = newcost;
dest.distance = pred.path_distance() - (edge->length() * remainder);
}
Expand Down
2 changes: 1 addition & 1 deletion src/thor/timedistancematrix.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ bool TimeDistanceMatrix::UpdateDestinations(
float remainder = dest_edge->second;
Cost newcost =
pred.cost() - (costing_->EdgeCost(edge, tile, time_info, flow_sources) * remainder);
if (newcost.cost < dest.best_cost.cost) {
if (newcost.cost > 0 && newcost.cost < dest.best_cost.cost) {
dest.best_cost = newcost;
dest.distance = pred.path_distance() - (edge->length() * remainder);
}
Expand Down
Loading