Skip to content

Fixed: Continuous Loading on UI When Selecting Facility Not Linked #709 - #411

Open
Nirvan-Bobde30 wants to merge 5 commits into
hotwax:mainfrom
Nirvan-Bobde30:fulfill/loadingUI#709
Open

Fixed: Continuous Loading on UI When Selecting Facility Not Linked #709#411
Nirvan-Bobde30 wants to merge 5 commits into
hotwax:mainfrom
Nirvan-Bobde30:fulfill/loadingUI#709

Conversation

@Nirvan-Bobde30

Copy link
Copy Markdown
Contributor

Continuous Loading on UI When Selecting Facility Not Linked with Product Store

Related Issues

#709 : Continuous Loading on UI When Selecting Facility Not Linked with Product Store

Short Description and Why It's Useful

  • Facility Selection: User should not be allowed to select such facility.
  • UI Response: The UI should either display an appropriate error message or notification indicating that the facility is not linked with the product store, rather than showing continuous loading.

Screenshots of Visual Changes before/after (If There Are Any)

Is the changes contains any breaking change?

If there are any breaking change include those in the release notes file

  • Yes
  • No

Contribution and Currently Important Rules Acceptance


<ion-list lines="none" v-if="eComStores.length === 0">
<ion-item v-if="appContext.hasPermission(appContext.Actions.APP_FACILITY_EDIT_PERMISSION)">
<div class="facility-route" >

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="facility-route" >
<div>

<ion-icon :icon="openOutline" slot="end"></ion-icon>
</ion-item>
<ion-item v-else>
<ion-label color="medium">{{ $t("There are no Product Stores linked to") }} {{ currentFacility.facilityName }} {{ $t(". Please contact your admin to finish this facilities setup") }}</ion-label>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ion-label color="medium">{{ $t("There are no Product Stores linked to") }} {{ currentFacility.facilityName }} {{ $t(". Please contact your admin to finish this facilities setup") }}</ion-label>
<ion-label color="medium">{{ $t("There are no Product Stores linked to") }} {{ currentFacility.facilityName }} {{ $t(". Please contact your admin to finish this facility setup") }}</ion-label>

const eComStores = computed(() => userStore.getProductStores);
const currentEComStore = computed(() => userStore.getCurrentEComStore);
const currentFacility = computed(()=>userStore.getCurrentFacility)
const copyPermissionErrorMessage = "https://docs.hotwax.co/documents/system-admins/administration/facilities/manage-product-stores"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const copyPermissionErrorMessage = "https://docs.hotwax.co/documents/system-admins/administration/facilities/manage-product-stores"
const supportRequestUrl = "https://docs.hotwax.co/documents/system-admins/administration/facilities/manage-product-stores"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants