Skip to content

fix(cmake): don't pass REQUIRED to find_dependency in package config #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoshimoe merged 1 commit into from
Jul 30, 2026
Merged

fix(cmake): don't pass REQUIRED to find_dependency in package config #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cmake/NekoFunctionConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
@PACKAGE_INIT@

# Find required dependencies
# Note: find_dependency() must not be given REQUIRED or QUIET; it forwards the
# REQUIRED/QUIET-ness requested by the caller of find_package(NekoFunction).
include(CMakeFindDependencyMacro)
find_dependency(NekoSchema REQUIRED)
find_dependency(NekoSchema)

# Find optional dependencies based on enabled features
# These are set during package configuration
set(NEKO_FUNCTION_HAS_HASH @NEKO_FUNCTION_ENABLE_HASH@)
set(NEKO_FUNCTION_HAS_ARCHIVE @NEKO_FUNCTION_ENABLE_ARCHIVE@)

if(NEKO_FUNCTION_HAS_HASH)
find_dependency(OpenSSL REQUIRED)
find_dependency(OpenSSL)
endif()

if(NEKO_FUNCTION_HAS_ARCHIVE)
find_dependency(minizip-ng REQUIRED)
find_dependency(minizip-ng)
endif()

# Include the targets file
Expand Down
Loading