Zano assets and enhancements#9389
Merged
Merged
Conversation
Zano fees are always paid in native ZANO, so when sending a confidential asset (FUSD etc.) the amount validator alone cannot catch an unaffordable fee: it checks the asset balance while the fee draws from the ZANO balance. Compare the estimated fee against the unlocked native balance (amount + fee for native sends), show an error under the fee cell and disable Next. Mirrors the checks already done in SendTransactionServiceZano for swaps.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughZano send handling now exposes native-asset balance data, checks fee affordability in the view model, prevents sending when fees are insufficient, and displays a conditional fee caution. The ZanoKit version reference was also updated. ChangesZano fee handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SendZanoScreen
participant SendZanoViewModel
participant ZanoAdapter
SendZanoScreen->>SendZanoViewModel: createState()
SendZanoViewModel->>ZanoAdapter: read native asset balance data
ZanoAdapter-->>SendZanoViewModel: isNativeAsset and nativeAvailableBalance
SendZanoViewModel-->>SendZanoScreen: SendZanoUiState with feeCaution
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rafaelekol
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9194
Summary by CodeRabbit
Bug Fixes
Improvements