fix(imp): return IMP_Mailbox objects from Vtrash mboxes#90
Merged
Conversation
IMP_Search_Vfolder_Vtrash::__get('mboxes') returned raw mailbox name
strings, but IMP_Search_Query consumers expect IMP_Mailbox objects
(e.g. the 'query' getter reads $mbox->container and 'querytext' reads
$val->display). Under PHP 8 this triggered repeated warnings:
Attempt to read property "container" on string
(lib/Search/Query.php line 270)
Wrap the result in IMP_Mailbox::get(), matching
IMP_Search_Vfolder_Vinbox and the base-class contract. This also fixes
a latent bug in IMP_Mailbox::expunge(), whose process list is
documented to contain IMP_Mailbox objects.
ralflang
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IMP_Search_Vfolder_Vtrash::mboxesto returnIMP_Mailboxobjects instead of raw strings.Motivation
Virtual Trash is queried/polled frequently, producing repeated PHP 8 warnings:
Attempt to read property "container" on stringatlib/Search/Query.php:270.The base
IMP_Search_Querygetters (query,querytext) expectIMP_Mailboxobjects, and
IMP_Search_Vfolder_Vinboxalready returns them.Changes
IMP_Mailbox::get(...)inVtrash::__get('mboxes').Test plan
IMP_Mailboxobjects in the process list).