Repository navigation
fix(linker): skip sandbox web/var dirs and dangling files - #29
Merged
Merged
Conversation
ApplicationLinker in proxy mode recursively copies app packages into web/$app. Accidental composer sandbox trees (web/, var/) committed in an app package can contain dangling JS symlinks; file_get_contents() then aborts horde:reconfigure and leaves web/$app empty (Rampage "No route"). Skip those directories in both symlink and proxy filters, and skip unreadable files before reading them.
ralflang
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/andvar/sandbox trees when linking Horde apps intoweb/$apphorde:reconfigureMotivation
composer update/horde:reconfigurefailed in proxy mode while linking Gollem:file_get_contents(.../vendor/horde/gollem/web/js/horde/accesskeys.js): No such file or directoryGollem's
FRAMEWORK_6_0branch contains leftover Composer sandbox directories (web/,var/) even though they are listed in.gitignore. Those trees include dangling JS symlinks whose relative targets only work at the deployment root.ApplicationLinkeremptiesweb/gollem/first, then dies on the dangling symlink, so the app has noindex.php. Apache rewrites/gollem/to Rampage, which has no Gollem routes, and the UI shows "No route matched".Changes
webandvarto the directory filter in both symlink and proxy modesis_file()/is_readable()beforefile_get_contents()so dangling links do not become ComposerErrorExceptionsApplicationLinkerTestcovering a Gollem-like sandbox tree with a danglingweb/js/horde/accesskeys.jssymlinkTest plan
vendor/bin/phpunit -c vendor/horde/horde-installer-plugin/phpunit.xml.dist --bootstrap vendor/autoload.php vendor/horde/horde-installer-plugin/test/ApplicationLinkerTest.phpcomposer horde:reconfigurecompletes with Gollem (or another app) still containing a leftoverweb/sandbox treeweb/gollem/index.phpexists after reconfigure/gollem/in the browser reaches the app (or login), not "No route matched"