Repository navigation
fix(themes): remove screen.css gate from theme discovery - #20
Merged
Merged
Conversation
A theme directory's existence under themes/{name}/ is sufficient
to be recognized. The screen.css check prevented apps with only
responsive.css or image-only themes from being symlinked.
ralflang
marked this pull request as ready for review
May 25, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screen.cssfile existence check fromThemesHandler::setupDefaultTheme()themes/{name}/is sufficient for recognitionresponsive.cssor image-only themes not getting symlinkedTest plan
composer horde:reconfigure --forceon an installation with passwdweb/themes/passwd/defaultsymlink is createdscreen.css