Skip to content

Unbundle sabberworm/php-css-parser - #6

Merged
ralflang merged 9 commits into
horde:FRAMEWORK_6_0from
powercycle:unbundle-parser
Mar 31, 2026
Merged

ralflang merged 9 commits into
horde:FRAMEWORK_6_0from
powercycle:unbundle-parser

Conversation

@powercycle

Copy link
Copy Markdown

Fixes #3

Used fixed version (8.9.0) of sabberworm/php-css-parser because 8-dev introduces a php deprecation.

Version 9+ seems to be architecture change.

www-data and others added 5 commits March 22, 2026 15:13
Fixes #3

Used fixed version of sabberworm/php-css-parser because 8-dev introduces
a php deprecation.  Version 9+ seems to be architecture change.
Release version 2.0.0-beta5

chore: Drop internal class loader in Css Parser class.
@TDannhauer
TDannhauer requested a review from ralflang March 31, 2026 07:22
@ralflang

Copy link
Copy Markdown
Member

First and foremost: THANK YOU!

Bad timing on my side, I released some hotfixes to the bundled version in parallel to you.
But your strategy is the right one moving forward. This thing should be unbundled, unleash the worms!

https://www.ralf-lang.de/2026/03/21/worms-infested-my-code-base-and-i-am-fighting-back/

I will have some work to do the remove the remaining architecture violations in IMP - the ones in horde core have already been resolved.

@powercycle - Please highlight Torben or me when making PRs for the time being - This should have been responded to immediately last week but it slipped through. All my fault!

@ralflang

Copy link
Copy Markdown
Member

See also issue #5

@ralflang ralflang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbundle and upgrade to the last compatible version. Great work. However I will defer the tagged release until I properly dealt with imp.

ralflang and others added 4 commits March 31, 2026 09:48
- Remove classmap for bundle dir
- Add dependency on sabberworm with caret condition (8.9.0 or newer but not 9.x)
Fixes #3

Used fixed version of sabberworm/php-css-parser because 8-dev introduces
a php deprecation.  Version 9+ seems to be architecture change.
- Remove classmap for bundle dir
- Add dependency on sabberworm with caret condition (8.9.0 or newer but not 9.x)
@ralflang
ralflang merged commit 6e08c58 into horde:FRAMEWORK_6_0 Mar 31, 2026
0 of 6 checks passed
@powercycle

Copy link
Copy Markdown
Author

Will do. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unbundle external CSS parser for FRAMEWORK_6_0

2 participants