Repository navigation
fix(core): import LanguageContextSelector in Nlsconfig - #235
Merged
Merged
Conversation
Nlsconfig lives in Horde\Core\Registry and implemented LanguageContextSelector without importing it, so PHP looked up Horde\Core\Registry\LanguageContextSelector and the injector could not create LanguageContext. Read the Accept-Language header from the promoted constructor property, and construct Nlsconfig in the unit test with the current argument order.
ralflang
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Horde\Core\LanguageContextSelectorinNlsconfigso the injector can createLanguageContext.Accept-Languageheader from the promoted constructor property.Nlsconfigin the unit test with the current argument order.Motivation
Nlsconfigis in namespaceHorde\Core\Registryand implementsLanguageContextSelectorwithout importing it. PHP therefore looked forHorde\Core\Registry\LanguageContextSelector, which does not exist. Date formatting requestsLanguageContext, and the injector failed withInterface "Horde\Core\Registry\LanguageContextSelector" not found.The same method used a bare
$serverEnvironment, so theAccept-Languagefallback never ran.Changes
use Horde\Core\LanguageContextSelectorinsrc/Registry/Nlsconfig.php.$this->serverEnvironmentinpreferredLang().BackendConfigLoader, then the optional environment and session, inNlsconfigTest::makeNlsconfig().Test plan
vendor/bin/phpunit --bootstrap vendor/autoload.php vendor/horde/core/test/Unit/Registry/NlsconfigTest.php(7 tests, 10 assertions)Cannot create Horde\Core\LanguageContextemergency log lines stop