Skip to content

refactor/language context decoupled from legacy registry - #228

Merged
ralflang merged 3 commits into
FRAMEWORK_6_0from
refactor/language-context-decoupled-from-legacy-registry
Oct 1, 2026
Merged

ralflang merged 3 commits into
FRAMEWORK_6_0from
refactor/language-context-decoupled-from-legacy-registry

Conversation

@ralflang

@ralflang ralflang commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Related to discussion in horde/whups#21

  • refactor: Extract Nlsconfig into a DI service
  • refactor: Extract Language handling into an Injectable service.
  • style: php-cs-fixer

@ralflang
ralflang requested a review from TDannhauer September 18, 2026 09:46
@ralflang

Copy link
Copy Markdown
Member Author

@TDannhauer This deserves some test driving before merge.

This allows application code to stop relying on $GLOBALS['language']

refactor: Wire up LanguageContext as the provider for DateFormatPrefs language
refactor: Registry internally uses LanguageContext (Horde\Core\Registry\Nlsconfig)
refactor: Move access to superglobal variable $_SERVER['HTTP_ACCEPT_LANGUAGE'] out of Nlsconfig into Factory
@ralflang
ralflang force-pushed the refactor/language-context-decoupled-from-legacy-registry branch from a0c69b6 to 2d8baf7 Compare October 1, 2026 14:21
@ralflang
ralflang merged commit 41e1566 into FRAMEWORK_6_0 Oct 1, 2026
1 check failed
ralflang added a commit to horde/whups that referenced this pull request Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant