Repository navigation
docs(activesync): note SPL-based exception classification as 6.1 follow-up - #114
Merged
Merged
Conversation
…ow-up Record why Status 6 is currently signalled through the Horde\Exception\InvalidDataThrowable marker (legacy <App>_Exception classes cannot extend an SPL type) and the target for the src/ stack: SPL bases such as HordeUnexpectedValueException plus the marker, with the driver classifying on both. Keeps the FRAMEWORK_6_0 lib/ check narrow. Follows the review note on horde/Exception#6.
🔍 CI ResultsOverall: ❌ 12/12 lanes failed TL;DR: ❌ Quality issues: PHP-CS-Fixer: 49 files. Summary by PHP Version
Quality Metrics
❌ Failed Lanesphp8.1-dev
php8.1-stable
php8.2-dev
php8.2-stable
php8.3-dev
php8.3-stable
php8.4-dev
php8.4-stable
php8.5-dev
php8.5-stable
php8.6-dev
php8.6-stable
CI powered by horde-components • View full results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doc/todo.md(FRAMEWORK_6_1 → Driver and backend shape): base thesrc/app exceptions on the SPL hierarchy (HordeUnexpectedValueExceptionfor constraint violations) while keeping theInvalidDataThrowablemarker for the retry-policy contract, and let thesrc/driver classify on both.Motivation
Follow-up to the review discussion on horde/Exception#6: the marker interface exists only because the legacy
<App>_Exceptionclasses extendHorde_Exception_Wrappedand cannot also extend an SPL type. This records the target state so it is not forgotten when the exceptions move tosrc/, and notes why thelib/_importFailure()check must stay narrow on FRAMEWORK_6_0.Changes
doc/todo.md— one bullet, documentation only.Test plan