Repository navigation
fix(activesync): heal ghost collections instead of FolderSync loops - #106
Merged
TDannhauer merged 1 commit intoSep 28, 2026
Merged
Conversation
🔍 CI ResultsOverall: ❌ 12/12 lanes failed TL;DR: ❌ Quality issues: PHPStan: 245 unique errors in 11 lanes; PHP-CS-Fixer: 35 files. Summary by PHP Version
Quality Metrics
❌ Failed Lanesphp8.0-dev
php8.0-stable
php8.1-dev
php8.1-stable
php8.2-dev
php8.2-stable
php8.3-dev
php8.3-stable
php8.4-dev
php8.4-stable
php8.5-dev
php8.5-stable
CI powered by horde-components • View full results |
Collections with a synckey but no folders cache entry cannot be repaired by incremental FolderSync (Count 0). PING Status 7 then livelocks cooperating clients. Restore the folders row from foldermap, or drop the ghost collection, instead of requesting FolderSync.
TDannhauer
force-pushed
the
fix/activesync-ghost-fsr-and-backlog-health
branch
from
September 18, 2026 21:31
f0c983e to
6bbd08f
Compare
TDannhauer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
folders[]cache entry, instead of answering PING with Status 7.Motivation
Incremental FolderSync cannot repair that cache skew: a valid hierarchy synckey yields Count 0. Cooperating clients then repeat empty PING → Status 7 → FolderSync indefinitely.
Changes
healCollectionsMissingFolderCache()restores a missing folders row from the persistent foldermap, or drops the collection when it is a true ghost.collectionsNeedFolderResync()now runs that heal and returns false. Missing hierarchy is still handled viahaveHierarchy().Test plan
CollectionsGhostFolderCacheTest,BacklogPingRecoveryTest,PingCollectionLockContentionTest