Skip to content

Fix hoopit-matt-picks manifest conflict (set strict: true) - #2

Merged
ezet merged 2 commits into
mainfrom
fix/matt-picks-strict-manifest
Jun 16, 2026
Merged

Fix hoopit-matt-picks manifest conflict (set strict: true)#2
ezet merged 2 commits into
mainfrom
fix/matt-picks-strict-manifest

Conversation

@Mounix99

@Mounix99 Mounix99 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Problem

hoopit-matt-picks installs but fails to load:

Plugin hoopit-matt-picks has conflicting manifests: both plugin.json and marketplace entry specify components. Set strict: true in marketplace entry or remove component specs from one location.

The marketplace entry declared strict: false and an explicit skills list, while upstream mattpocock/skills ships its own .claude-plugin/plugin.json that also declares components. Claude Code rejects the two component sources as conflicting.

Fix

Set strict: true on the hoopit-matt-picks entry. This makes the curated 5-skill list in marketplace.json authoritative — exactly the intent of "curated picks from mattpocock/skills" — and resolves the load failure. All 5 listed skill paths exist upstream.

Validated locally with claude plugin validate (✔ passed). Reproduced the original failure and confirmed the entry now loads after the change.

🤖 Generated with Claude Code


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Chores
    • Tightened marketplace validation for the curated hoopit-matt-picks skill source by enabling stricter matching.
    • Updated guidance and README instructions to reflect that the explicitly curated skills list is now authoritative and will override upstream manifest entries.

The hoopit-matt-picks marketplace entry declared both `strict: false`
and an explicit `skills` list, while the upstream mattpocock/skills
plugin.json also declares its own components. Claude Code rejects this
as conflicting manifests, so the plugin installs but fails to load:

  Plugin hoopit-matt-picks has conflicting manifests: both plugin.json
  and marketplace entry specify components. Set strict: true in
  marketplace entry or remove component specs from one location.

Setting `strict: true` makes the curated 5-skill list in this entry
authoritative, which is the intended behavior for "curated picks",
and resolves the load failure.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f6d17988-1994-44d7-946b-4df81818f0f2

📥 Commits

Reviewing files that changed from the base of the PR and between 14c824e and 8010252.

📒 Files selected for processing (2)
  • .claude/skills/create-hoopit-skill/SKILL.md
  • README.md

Walkthrough

The hoopit-matt-picks plugin configuration is updated to enable strict mode across three files. In .claude-plugin/marketplace.json, the source object's strict flag changes from false to true. The README and SKILL.md documentation are updated to reflect that strict mode makes the curated skills array authoritative, preventing upstream manifest overrides.

Changes

Plugin Strict Mode Configuration and Documentation

Layer / File(s) Summary
Enable strict flag in marketplace.json
.claude-plugin/marketplace.json
The strict field within the source object of the hoopit-matt-picks plugin entry is toggled from false to true.
Update documentation for strict mode behavior
.claude/skills/create-hoopit-skill/SKILL.md, README.md
SKILL.md authoring guidance and README configuration snippet are updated to specify strict: true and clarify that the curated skills array becomes authoritative and overrides upstream plugin manifests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny toggled strict to true,
From false to firm, the change shines through.
Three files sync in harmony,
The curated list shall reign so free! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing a manifest conflict by setting strict: true on the hoopit-matt-picks plugin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/matt-picks-strict-manifest

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude-plugin/marketplace.json:
- Line 32: The marketplace.json file now sets strict mode to true for the
plugin, but the documentation describing the hoopit-matt-picks plugin
configuration has not been updated to match. Update README.md lines 45-51 to
change the documented behavior from strict: false to strict: true, and also
update .claude/skills/create-hoopit-skill/SKILL.md lines 69-76 with the same
correction so that all references to the strict mode setting reflect the current
manifest configuration and maintain consistency across the repository.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3d26515d-0dc1-4f7f-847a-6c5f8976d641

📥 Commits

Reviewing files that changed from the base of the PR and between 20930c9 and 14c824e.

📒 Files selected for processing (1)
  • .claude-plugin/marketplace.json

Comment thread .claude-plugin/marketplace.json
Update README.md and create-hoopit-skill/SKILL.md to describe
hoopit-matt-picks as strict: true, matching the manifest change, and
explain why strict mode is required (overrides the upstream plugin's
own manifest instead of conflicting with it).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Resolves a Claude Code plugin load failure for hoopit-matt-picks caused by conflicting component declarations between the upstream repo’s .claude-plugin/plugin.json and this marketplace entry, by making the marketplace’s curated skills list authoritative.

Changes:

  • Set "strict": true for the hoopit-matt-picks entry in .claude-plugin/marketplace.json to avoid manifest/component conflicts.
  • Updated README documentation to explain why strict: true is required for this GitHub-sourced, curated plugin.
  • Updated the internal authoring guide (create-hoopit-skill) to reflect the same strict: true rationale for future maintenance.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
README.md Documents that hoopit-matt-picks uses strict: true so the curated skills list overrides upstream manifest components.
.claude/skills/create-hoopit-skill/SKILL.md Updates maintainer guidance to require strict: true for hoopit-matt-picks due to upstream manifest presence.
.claude-plugin/marketplace.json Switches hoopit-matt-picks to "strict": true to resolve the manifest conflict and allow the plugin to load.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ezet
ezet merged commit a8977d5 into main Jun 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants