Skip to content

fix(ci): stabilize nightly verification lanes - #3157

Draft
mikemcdougall wants to merge 2 commits into
trunkfrom
agent/fix-nightly-workflows
Draft

fix(ci): stabilize nightly verification lanes#3157
mikemcdougall wants to merge 2 commits into
trunkfrom
agent/fix-nightly-workflows

Conversation

@mikemcdougall

@mikemcdougall mikemcdougall commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Issue Link

Closes #1372
Closes #1240

Summary

Stabilizes the nightly verification lanes and removes the unusable licensed ArcGIS Pro evidence workflow. Portal compatibility is verified through the maintained honua-esri-compat harness.

Changes Made

  • Bound the nightly load-test database connection admission settings to the GitHub runner budget.
  • Corrected migration approval resource nonces, Oracle field-name resolution, client-compat error expectations, and CITE WMS runner exit handling.
  • Removed the unexecutable self-hosted ArcGIS Pro evidence workflow.

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Architecture tests pass
  • Manual testing performed

Gate Impact

  • PR gates (build, test, governance)
  • Nightly gates (conformance, performance, security)
  • Release gates (packaging, publishing)
  • Deploy gates (promotion, post-apply validation)
  • None — no gate impact

Docs or Contract Impact

  • OpenAPI spec changed
  • Protobuf/gRPC contract changed
  • Control plane SDK surface changed
  • Documentation updated
  • None — no docs or contract impact

Release/Deploy Impact

  • Requires coordinated release across repos
  • Requires database migration
  • Requires infrastructure changes
  • Requires environment variable or secret changes
  • None — standard merge-and-release flow

Breaking Changes

None


Pre-PR Checklist

  • Ran scripts/ci/pre-pr-check.sh and all checks passed (the script exceeded five minutes without output locally)
  • Commit messages follow conventional format: type: description (#issue)
  • PR title matches main commit message
  • Issue number linked above
  • Tests added for new functionality
  • If protocol/auth behavior changed: updated compatibility contract
  • If breaking admin/control-plane API changes: updated migration guide
  • OPENAPI_BREAKING_CHANGE_APPROVED — intentional Admin API break acknowledged for this PR
  • If breaking gRPC/proto wire changes: confirmed with explicit review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant