feat(collaboration): persist operation checkpoint cursors (#3067) - #3121
feat(collaboration): persist operation checkpoint cursors (#3067)#3121mikemcdougall wants to merge 2 commits into
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1539e76bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| -- The head row is the per-map serialization point for cursor assignment. Keeping the | ||
| -- checkpoint cursor on that same row gives operation replay and checkpoint replay one | ||
| -- durability/locking story instead of pairing a durable log with process-local state. | ||
| CREATE TABLE IF NOT EXISTS honua.saved_map_operation_log_heads ( |
There was a problem hiding this comment.
When Database:Schema is set to anything other than honua, the new DI registration passes that value to PostgresSavedMapOperationLogRepository, so every query targets the configured schema, but this migration still creates both tables only in honua. The migration therefore reports success while the first append or replay fails with relation does not exist; notably, the integration test avoids the production behavior by manually replacing honua. in the script. The migration and repository need to agree on the schema.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Pull Request
Issue Link
Related to #3067
Summary
Adds the durable saved-map operation-log and checkpoint-cursor storage foundation in one Postgres store. This is an intentionally draft, independently reviewable slice: wiring
SavedMapCheckpointOperationLoginto this store and proving restart behavior end to end remains stacked on PR #3035.Changes Made
Testing
Postgres Release build passed with zero warnings/errors; focused Core tests passed 11/11; targeted format verification and diff checks passed. Docker Desktop is unavailable on this host, so the two Postgres integration cases compiled but could not execute their assertions locally.
Gate Impact
Docs or Contract Impact
Release/Deploy Impact
Breaking Changes
None
Pre-PR Checklist
scripts/ci/pre-pr-check.shand all checks passedtype: description (#issue)