feat: verify governed staging binding - #193
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9d7fed9e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| descriptor_ref = binding.get("descriptor") | ||
| target = binding.get("target") | ||
| access = binding.get("access") | ||
| if not all(isinstance(value, dict) for value in (owner, descriptor_ref, target, access)): |
There was a problem hiding this comment.
When the staging variable omits source entirely, names another repository/workflow, or gives a commit different from the commit embedded in the descriptor URL, this validator still accepts it because only owner, descriptor, target, and access are required. The workflow can therefore emit a passing governed receipt without evidence that the descriptor came from the claimed terminal demo-infra deployment; require source and cross-check its repository and commit against the allowlisted descriptor reference.
Useful? React with 👍 / 👎.
1 participant
Summary
Rollout dependency
The staging variable must be populated from a terminal demo-infra deployment artifact produced by honua-io/honua-demo-infra#32 before the remote workflow can certify this change. This PR does not update that variable or any credential.
Focused validation
Refs honua-io/honua-demo-infra#28