feat: Add support for message keys in typed producer - #88
Conversation
31c6514 to
20a0400
Compare
20a0400 to
1fa8cfe
Compare
1fa8cfe to
58a2722
Compare
| } | ||
|
|
||
| if key != nil { | ||
| msg.Key = key |
There was a problem hiding this comment.
If the default value of msg.Key is nil, then can we skip checking if key is nil?
| kafka: | ||
| local-kafka1: | ||
| image: confluentinc/cp-kafka:5.5.5 | ||
| image: confluentinc/cp-kafka:7.3.2 |
There was a problem hiding this comment.
This file is supposed to be synced from .github as mentioned in the comment above. Can we follow the same?
| tar -xzf kafka_2.13-3.2.3.tgz | ||
| ./kafka_2.13-3.2.3/bin/kafka-topics.sh --bootstrap-server localhost:9092 --list | ||
| ./kafka_2.13-3.2.3/bin/kafka-topics.sh --bootstrap-server localhost:9092 --list | ||
| wget https://downloads.apache.org/kafka/3.4.1/kafka_2.13-3.4.1.tgz |
There was a problem hiding this comment.
Not sure, why this file is not synced from .github though
There was a problem hiding this comment.
Looks like we are performing these extra steps specific to KP. To sync them from workflows, we'd have to copy over these to that repo, and sync from there. Doing that for a single repository doesn't seem worth the effort.
There was a problem hiding this comment.
In general i feel this file can very much be synced from .github and maybe use one of the existing ones. If we feel like we need separate steps for integration tests then we can use a build file without the int tests from .github and a custom integration_tests.yaml file.
There was a problem hiding this comment.
I've created a linear ticket for this https://linear.app/honestbank/issue/NERDS-236/sync-kp-workflows-from-the-shared-workflows
|
Kudos, SonarCloud Quality Gate passed! |









Pull Request Submission Checklist
Please confirm that you have done the following before requesting reviews:
the Honest Pull Request and Commit Message Naming Conventions.
Description
AC
This change is