Skip to content

Move Piper source to home-assistant/app-piper - #4934

Open
sairon wants to merge 1 commit into
masterfrom
split-piper
Open

sairon wants to merge 1 commit into
masterfrom
split-piper

Conversation

@sairon

@sairon sairon commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Keep only the app index metadata in piper/.

Refs #4887

Summary by CodeRabbit

  • Chores
    • The app catalog now lists Piper and points to its external repository and container image.
    • The previous Piper build and runtime setup has been removed from this repository, including its voice-pack installation and Home Assistant discovery configuration.

Keep only the app index metadata in piper/.

Refs #4887
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Walkthrough

The app registry now maps Piper to its repository, target, and image. The local Piper image build definition and s6 runtime files are removed. Yamllint now ignores /piper/config.yaml.

Changes: Piper app registration and implementation removal

Layer / File(s) Summary
Register Piper
.apps.yml, .yamllint
Adds the Piper repository, target, and image mapping. Adds /piper/config.yaml to the yamllint ignore list.
Remove the local image build definition
piper/Dockerfile, piper/build.yaml
Removes the Dockerfile and build configuration for the Debian Trixie images.
Remove Piper runtime services
piper/rootfs/etc/s6-overlay/s6-rc.d/*
Removes Piper service startup and exit handling, pack installation, and Home Assistant discovery scripts and declarations.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor

Suggested reviewers: synesthesiam

Merge Risk: Minimal · up to 76afa

This change moves Piper's source to a separate repository and keeps only the app index metadata. No concrete merge-blocking issue was found. The first release from the new repository should be confirmed after merge.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: moving the Piper source to the separate home-assistant/app-piper repository while retaining app metadata.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ca456376-eaf2-43e9-b37b-6ef5633fb867
Commits

Reviewing files that changed from the base of the PR and between c23035a and 76afa7d.

Files selected for processing: 20

  • .apps.yml
  • .yamllint
  • piper/Dockerfile
  • piper/build.yaml
  • piper/rootfs/etc/s6-overlay/s6-rc.d/discovery/dependencies.d/piper
  • piper/rootfs/etc/s6-overlay/s6-rc.d/discovery/run
  • piper/rootfs/etc/s6-overlay/s6-rc.d/discovery/type
  • piper/rootfs/etc/s6-overlay/s6-rc.d/discovery/up
  • piper/rootfs/etc/s6-overlay/s6-rc.d/packs/dependencies.d/base
  • piper/rootfs/etc/s6-overlay/s6-rc.d/packs/run
  • piper/rootfs/etc/s6-overlay/s6-rc.d/packs/type
  • piper/rootfs/etc/s6-overlay/s6-rc.d/packs/up
  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/dependencies.d/base
  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/dependencies.d/packs
  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/finish
  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/run
  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/type
  • piper/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/discovery
  • piper/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/packs
  • piper/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/piper
Files with no reviewable changes: 18

  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/type
  • piper/rootfs/etc/s6-overlay/s6-rc.d/discovery/run
  • piper/build.yaml
  • piper/rootfs/etc/s6-overlay/s6-rc.d/packs/up
  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/dependencies.d/packs
  • piper/rootfs/etc/s6-overlay/s6-rc.d/packs/dependencies.d/base
  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/run
  • piper/rootfs/etc/s6-overlay/s6-rc.d/discovery/dependencies.d/piper
  • piper/Dockerfile
  • piper/rootfs/etc/s6-overlay/s6-rc.d/discovery/type
  • piper/rootfs/etc/s6-overlay/s6-rc.d/packs/run
  • piper/rootfs/etc/s6-overlay/s6-rc.d/packs/type
  • piper/rootfs/etc/s6-overlay/s6-rc.d/discovery/up
  • piper/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/piper
  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/dependencies.d/base
  • piper/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/packs
  • piper/rootfs/etc/s6-overlay/s6-rc.d/piper/finish
  • piper/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/discovery
Files skipped from review as they are similar to previous changes: 1

  • .yamllint

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant