[sairon]

Keep only the app index metadata in samba/.

Refs #4889

Summary by CodeRabbit

• Changes
  • The Samba app registry entry now points to home-assistant/app-samba and its published container image.
  • The repository no longer contains its previous Samba service build, startup, share-configuration, or network-discovery files. The effect of this change on existing Samba installations may depend on how the referenced app is provided and updated.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The registry adds a Samba app entry for home-assistant/app-samba. The repository removes the local image build, Samba setup and configuration, and supervised smbd, nmbd, and wsdd services.

Changes: Samba app registry and implementation

Layer / File(s)	Summary
Register the app and remove the local image build .apps.yml, .yamllint, samba/Dockerfile, samba/build.yaml	The registry adds the Samba app entry with its repository, target, and image. The local Dockerfile and build configuration are removed. The YAML lint ignore list adds /samba/config.yaml.
Remove Samba setup and share configuration samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/*, samba/rootfs/usr/share/tempio/smb.gtpl	The interface helper, initialization script, initialization service metadata, and Samba configuration template are removed.
Remove supervised Samba and discovery services samba/rootfs/etc/s6-overlay/s6-rc.d/nmbd/*, samba/rootfs/etc/s6-overlay/s6-rc.d/smbd/*, samba/rootfs/etc/s6-overlay/s6-rc.d/wsdd/*, samba/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/wsdd, samba/rootfs/etc/s6-overlay/scripts/enable-check.sh	The nmbd, smbd, and wsdd service definitions and launch scripts are removed. The script that enabled or disabled service markers is also removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: lmagyar, madbrain76

Merge Risk: Minimal · up to 691c4

The Samba implementation is replaced by the registered external app, with no actionable merge-blocking risk identified.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: moving the Samba share source to home-assistant/app-samba.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 001b2325-2be3-4332-aaf1-c2bd0bf3104b

Commits

Reviewing files that changed from the base of the PR and between 20b8eea and 691c4b8.

Files selected for processing: 27

• .apps.yml
• .yamllint
• samba/Dockerfile
• samba/build.yaml
• samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/dependencies.d/base
• samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/network-interfaces.sh
• samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/run
• samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/type
• samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/up
• samba/rootfs/etc/s6-overlay/s6-rc.d/nmbd/dependencies.d/smbd
• samba/rootfs/etc/s6-overlay/s6-rc.d/nmbd/finish
• samba/rootfs/etc/s6-overlay/s6-rc.d/nmbd/run
• samba/rootfs/etc/s6-overlay/s6-rc.d/nmbd/type
• samba/rootfs/etc/s6-overlay/s6-rc.d/smbd/dependencies.d/init-smbd
• samba/rootfs/etc/s6-overlay/s6-rc.d/smbd/finish
• samba/rootfs/etc/s6-overlay/s6-rc.d/smbd/run
• samba/rootfs/etc/s6-overlay/s6-rc.d/smbd/type
• samba/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/init-smbd
• samba/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/nmbd
• samba/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/smbd
• samba/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/wsdd
• samba/rootfs/etc/s6-overlay/s6-rc.d/wsdd/dependencies.d/init-smbd
• samba/rootfs/etc/s6-overlay/s6-rc.d/wsdd/finish
• samba/rootfs/etc/s6-overlay/s6-rc.d/wsdd/run
• samba/rootfs/etc/s6-overlay/s6-rc.d/wsdd/type
• samba/rootfs/etc/s6-overlay/scripts/enable-check.sh
• samba/rootfs/usr/share/tempio/smb.gtpl

Files with no reviewable changes: 19

• samba/rootfs/etc/s6-overlay/s6-rc.d/wsdd/dependencies.d/init-smbd
• samba/rootfs/etc/s6-overlay/s6-rc.d/nmbd/type
• samba/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/wsdd
• samba/build.yaml
• samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/type
• samba/rootfs/etc/s6-overlay/s6-rc.d/smbd/run
• samba/rootfs/usr/share/tempio/smb.gtpl
• samba/rootfs/etc/s6-overlay/s6-rc.d/smbd/finish
• samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/up
• samba/rootfs/etc/s6-overlay/s6-rc.d/wsdd/type
• samba/rootfs/etc/s6-overlay/s6-rc.d/nmbd/run
• samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/run
• samba/rootfs/etc/s6-overlay/s6-rc.d/init-smbd/network-interfaces.sh
• samba/rootfs/etc/s6-overlay/s6-rc.d/wsdd/run
• samba/rootfs/etc/s6-overlay/s6-rc.d/nmbd/finish
• samba/Dockerfile
• samba/rootfs/etc/s6-overlay/s6-rc.d/smbd/type
• samba/rootfs/etc/s6-overlay/scripts/enable-check.sh
• samba/rootfs/etc/s6-overlay/s6-rc.d/wsdd/finish

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.