fix: initialize Minestom LoginListener at run time for native image#910
Merged
Merged
Conversation
…reRandom stays out of the native image heap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
map-isolatenative image build fails during analysis:Minestom's
LoginListenerholds astatic SecureRandom.HCNativeImageFeatureblanket-initializes everynet.minestom.*package at build time, so that field is constructed during image generation and lands in the image heap — which GraalVM forbids forRandom/SecureRandom(cached seed values). This surfaced after the recent Minestom update.A
--initialize-at-build-time=java.security.SecureRandomflag does not help — GraalVM'sDisallowedImageHeapObjectscheck rejects such instances regardless of init policy. The instance simply must not be created at build time.Fix
Initialize
LoginListenerat run time so itsSecureRandomis never constructed during image generation. This follows the existing precedent in the same file (PlayerSocketConnection,NetworkBufferImpl, etc. are already runtime-init'd to override the blanket package init).Verification
./gradlew :bin:map-isolate:nativeCompilenow succeeds locally (Finished generating 'map-isolate' in 2m 46s, 125 MB executable produced).