editing pass from the docs team#1
Open
holdenhewett wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thanks for your contribution! Please see the following feedback and suggestions that I've submitted in this PR to align this doc with Shopify's dev doc quality standards (see Content Help documentation):
General feedback:
Content organization
Content style
Accessibility and usability
catand a here document (<<EOF) to redirect the output to a file. Instead, just instruct readers to create the file and to add the code snippet's content to it. Removing this complexity will help more novice readers focus on what they're learning in the tutorial and not get distracted by unnecessary complexity.Source code formatting
highlighttemplate for code snippets instead of the semantic Markdown when you need to refer to specific lines in them. This will better draw attention to lines that you call out in the context surrounding the code snippets.{{% code_sample file="pods/config/redis-pod.yaml" %}}template works, but it lacks the ability to highlight specific lines of code like ahighlighttemplate does. Being able to highlight lines in longer files is especially useful to get readers looking directly at what's important instead of having to search for it.