feat: resolve stack base from forge CLI when config omits repo.base - #73
Merged
Conversation
simtel12
force-pushed
the
pgit/gregorios-leach/feat--resolve-stack-base-from-forge-cli-when-confi
branch
2 times, most recently
from
May 1, 2026 09:44
2635227 to
78c7952
Compare
hokwangchoi
requested changes
May 1, 2026
| "github" => super::github::try_cli_default_stack_base(repo), | ||
| // Future: "gitlab" => super::gitlab::try_cli_default_stack_base(repo), | ||
| // Future: "gitea" => super::gitea::try_cli_default_stack_base(repo), | ||
| _ => None, |
Owner
There was a problem hiding this comment.
Please leave them as unimplemented!() for now instead of silent passthrough
Author
There was a problem hiding this comment.
Won't that break things for any non-github users? The current path falls through to previous behavior/attempting to use heuristics to determine the base.
Owner
There was a problem hiding this comment.
I see, this is not the last resolution. Then, it's fine to leave it as is.
Author
There was a problem hiding this comment.
Order is:
- Config file
- CLI default (this)
- git heuristics (
main|master)
Add stack_base_hint::try_from_forge_cli as the extension point for hosting defaults; implement GitHub via gh repo view defaultBranchRef (origin/<name> or local branch when present). Precedence remains: explicit [repo].base, forge CLI hint, then git heuristics. Pass forge type from repo_loader into resolve_base. Made-with: Cursor
simtel12
force-pushed
the
pgit/gregorios-leach/feat--resolve-stack-base-from-forge-cli-when-confi
branch
from
May 1, 2026 17:36
28376fe to
1b16216
Compare
hokwangchoi
approved these changes
May 1, 2026
simtel12
deleted the
pgit/gregorios-leach/feat--resolve-stack-base-from-forge-cli-when-confi
branch
May 1, 2026 18:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add stack_base_hint::try_from_forge_cli as the extension point for hosting defaults; implement GitHub via gh repo view defaultBranchRef (origin/ or local branch when present).
Precedence remains: explicit [repo].base, forge CLI hint, then git heuristics. Pass forge type from repo_loader into resolve_base.