Skip to content

fix: chat-enter key, mod-version set, streamer range#14

Merged
Kheartz merged 3 commits into
mainfrom
mp_fixes
Jun 13, 2026
Merged

fix: chat-enter key, mod-version set, streamer range#14
Kheartz merged 3 commits into
mainfrom
mp_fixes

Conversation

@Kheartz

@Kheartz Kheartz commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Various fixes:

  1. Enter key would sometimes flicker when using the chat
  2. modVersion needs to be set so client can connect to server (was stuck at handshake)
  3. Scale streamer range properly to HL distances

Kheartz added 3 commits June 13, 2026 18:20
Opening chat with Enter (polled IsKeyPressed) let that same keypress be
read as a submit by ImGui's InputText on the frame it gained focus, so
the box flickered open then shut. Gate submit on the Enter being released
(ImGui::IsKeyDown), which is frame-timing independent.
ClientHandshake::Valid() requires every version field non-empty, but
modVersion was never set, so the server rejected the handshake (message
136) and clients could not connect. Set modVersion to "0.1.0" (matches
the server's value).
The framework default Streamer.range is 100 units (~1 m in Hogwarts'
cm scale), so anything more than a step away never streamed to clients.
Set 50000 (~500 m) on player connect.
@Kheartz Kheartz merged commit 2b60f14 into main Jun 13, 2026
1 check passed
@Kheartz Kheartz deleted the mp_fixes branch June 13, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant