Skip to content

Content edits - #958

Open
JackHMRC wants to merge 3 commits into
mainfrom
Forms-in-a-detailed-guide-content-edits
Open

Content edits#958
JackHMRC wants to merge 3 commits into
mainfrom
Forms-in-a-detailed-guide-content-edits

Conversation

@JackHMRC

Copy link
Copy Markdown
Contributor

No description provided.

@JackHMRC
JackHMRC requested review from Jon-Rowe-HMRC and timsb March 18, 2025 15:56
If it is, do not repeat it. Add a link and journey to that content instead.
</p>

<h3 class="govuk-heading-m" id="Detailed examples">Types of forms</h3>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the right ID

<li>G-forms — these are added as external links. The URL will begin with https://tax.service.gov.uk</li>
<li>forms in open document formats — forms in .ods or odt. format are added as file attachments</li>
<li>KANA forms — these are added as external links. The URL will begin with https://online.hmrc.gov.uk/shortforms</li>
<li><strong>Online services</strong>these are built by service teams on the tax platform behind the Government Gateway, accessed with a green button. The URL, starts with https://www.taxservices.gov.uk/’ often followed by ‘/digital-forms/form/form-name’.</li>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't usually use quote marks (and it's inconsistent with some similar examples elsewhere on the page)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/’ often followed by ‘/
^ this isn't correct as you'd have // in the URL

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using bold like this contradicts the GDS style guide

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GDS bullet lists aren't sentences

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://www.taxservices.gov.uk/ should be https://www.tax.service.gov.uk/?

<li><strong>PDFs that cannot be completed on screen</strong> — these are added as file attachments and do not require Adobe to open</li>
<li><strong>LC forms</strong> — these are added as external links. The URL will begin with https://public-online.hmrc.gov.uk/lc/content</li>
<li><strong>G-forms</strong>a common alternative to an online service usually accessed with a green button. The URL will begin with https://tax.service.gov.uk/submissions.</li>
<li><strong>Open document forms</strong>these are forms in .ods or odt. Format that are added as file attachments.</li>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'odt. F' > '.odt f'

</ul>
<li><a href="https://www.gov.uk/guidance/register-a-non-resident-company-who-disposed-of-uk-property-or-land-for-corporation-tax" class="govuk-link">
Register a non-resident company who disposed of UK property or land for Corporation Tax</a> — G-form</li>
<li><a href="https://www.gov.uk/guidance/work-out-pay-from-an-umbrella-company" class="govuk-link">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line returns shouldn't be inside HREFs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jon-Rowe-HMRC Whitespace in HTML is largely ignored so shouldn't be a problem here but it is arguably easier to read the code when on the same line.

https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model/Whitespace

<li>eligibility criteria</li>
</ul>

<h3 class="govuk-heading-m" id="Detailed examples">Check for duplicate guidance first</h3>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the wrong ID?

Comment thread src/patterns-hmrc-govuk-team/forms-detailed-guide/index.njk Outdated
Comment thread src/patterns-hmrc-govuk-team/forms-detailed-guide/index.njk Outdated
</ul>
<li><a href="https://www.gov.uk/guidance/register-a-non-resident-company-who-disposed-of-uk-property-or-land-for-corporation-tax" class="govuk-link">
Register a non-resident company who disposed of UK property or land for Corporation Tax</a> — G-form</li>
<li><a href="https://www.gov.uk/guidance/work-out-pay-from-an-umbrella-company" class="govuk-link">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jon-Rowe-HMRC Whitespace in HTML is largely ignored so shouldn't be a problem here but it is arguably easier to read the code when on the same line.

https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model/Whitespace

JackHMRC and others added 2 commits March 20, 2025 14:12
Co-authored-by: Timothy Bryan <timsb@users.noreply.github.com>
Co-authored-by: Timothy Bryan <timsb@users.noreply.github.com>
@JackHMRC
JackHMRC requested review from Jon-Rowe-HMRC and timsb March 20, 2025 14:14
<li>G-forms — these are added as external links. The URL will begin with https://tax.service.gov.uk</li>
<li>forms in open document formats — forms in .ods or odt. format are added as file attachments</li>
<li>KANA forms — these are added as external links. The URL will begin with https://online.hmrc.gov.uk/shortforms</li>
<li><span class="govuk-!-font-weight-bold">Online services</span>these are built by service teams on the tax platform behind the Government Gateway, accessed with a green button. The URL, starts with https://www.taxservices.gov.uk/’ often followed by ‘/digital-forms/form/form-name’.</li>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <span class="govuk-!-font-weight-bold"> needs to be done for all the <strong> tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants