notification-badge-navigation - #912
Open
Edem-Ag wants to merge 6 commits into
Open
Conversation
Jon-Rowe-HMRC
requested changes
Oct 17, 2024
Jon-Rowe-HMRC
left a comment
Jon-Rowe-HMRC
left a comment
Contributor
There was a problem hiding this comment.
'The notification badge is a number displayed to the right-hand side of the service navigation.' > 'The notification badge is a number displayed to the right-hand side of the service navigation link it refers to.'
Also, the example link needs to have the correct class (see service navigation component).
Edem-Ag
commented
Oct 17, 2024
Edem-Ag
left a comment
Edem-Ag
left a comment
Contributor
Author
There was a problem hiding this comment.
just realised I have 2 classes on 10
Contributor
|
Needs to use the link classes from https://design-system.service.gov.uk/components/service-navigation/ |
Contributor
Author
|
Hey @timsb We've used a service navigation class in the example. Over to you to integrate the GOVUK css? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.