Skip to content

Updating service-timeout to add content attribute and message-suffix #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
timsb wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Updating service-timeout to add content attribute and message-suffix #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"homepage": "https://github.com/hmrc/design-system#readme",
"dependencies": {
"govuk-frontend": "^3.6.0",
"hmrc-frontend": "^1.13.0"
"hmrc-frontend": "^1.15.2"
},
"devDependencies": {
"autoprefixer": "^9.6.5",
Expand Down
9 changes: 5 additions & 4 deletions src/hmrc-design-patterns/service-timeout/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,19 @@ layout: twoColumnPage.njk
height: 400
}) }}

{#{ example({
{{ example({
item: 'service-timeout',
example: 'saved',
description: 'Saved service timeout',
height: 400
}) }#}
}) }}

{#{ example({
{{ example({
item: 'service-timeout',
example: 'not-saved',
description: 'Not saved service timeout',
height: 400
}) }#}
}) }}

<p class="govuk-body">If they do nothing, take them to a ‘We signed you out’ page that uses similar content as the warning box.</p>

Expand Down Expand Up @@ -119,6 +119,7 @@ layout: twoColumnPage.njk
codeSnippet({
code: '<meta
name="hmrc-timeout-dialog"
content="hmrc-timeout-dialog"
data-timeout=""
data-countdown=""
data-keep-alive-url=""
Expand Down