Fix View Bill missing Item and Quantity on Direct Issue to BHT Return#22054
Conversation
Reload the BHT return bill with its billItems before navigating to the reprint page. Previously the detached bill's billItems were never fetched, so the Item/QTY table rendered empty. Also add a "Manage Bill" action alongside "View Bill" so both are available from the direct issues list. Closes #22035 Signed-off-by: Dr M H B Ariyaratne <buddhika.ari@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (18)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…and A4/FiveFive/POS print formats Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rge/Discount print formats Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…-issue bill (#22035) - Add three application-wide boolean properties: inwardDirectIssueBillA4, inwardDirectIssueBillFiveFive, inwardDirectIssueBillPos - Load config from configOptionApplicationController in loadCurrentConfig() - Add dedicated saveInwardDirectIssueBillPaperConfig() action method - Add EL-bindable is*/set* accessors for JSF binding Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…fig dialog on direct-issue page (#22035) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…e Charge/Discount (#22035)
…Service Charge/Discount (#22035)
…Bill and add A4/FiveFive/POS formats (#22035) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…n + reprint-return pages (#22035) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… avoid nested forms (#22035) Nested h:form inside the page-level h:form is invalid and can break the Apply postback binding. Relocate the idi* config dialogs to page-level siblings of the outer form, matching pharmacy_reprint_bill_sale_bht.xhtml. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…per-type previews against double-print (#22035) - pharmacy_reprint_bill_return_bht: relabel View Bill 'Matrix Value' to 'Service Charge' and add a Discount column (colspan 4->5), matching the reprint-sale page. - Guard legacy departmentPreference.pharmacyBillPaperType preview panels on the return + reprint-sale pages so they render only when none of the new A4/FiveFive/POS format keys is active, preventing two stacked previews. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… reconciles with Discount (#22035) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 participant
Summary
On the Direct Issue to BHT Return page, clicking View Bill did not display the Item and Quantity details, so users could not verify the returned items.
Root cause: When reached from the BHT Issue Return page,
billis a detached entity whosebillItemswere never fetched, so the reprint page's Item/QTY table rendered empty.Changes
PharmacyBillSearch.java— reload the bill with itsbillItems(viabillBean.fetchBillWithItemsAndFees) before navigating to the reprint page, so the Item/QTY table is populated.pharmacy_reprint_bill_sale_bht.xhtml— relabel the page header to Manage Direct Issue to BHT.inpatient_pharmacy_direct_issues_list.xhtml— add a Manage Bill action alongside View Bill, so both are available from the direct issues list. View Bill now routes throughnavigateToViewBillByAtomicBillTypeByBillId.Follow-up: Service Charge / Discount on printed bills + A4/FiveFive/POS formats
Extended the inpatient direct-issue bill family so every printed/preview bill shows, per item and at bill level, Gross / Service Charge / Discount / Net (margin is labelled "Service Charge" at every location), selectable across A4 / FiveFive / POS paper via a standard print-config gear dialog.
What changed
PrintBillData) for the native direct-issue page, three entity-based (Bill) for the issue side of the return/reprint pages, and three entity-based for the return side — each in A4, FiveFive and POS layouts. All show the four money columns per item and at bill level.PharmacyConfigControllergains three application-wide keys —Pharmacy Inward Direct Issue Bill is A4(default off) /is FiveFive(default on) /is POS(default off) — plus asaveInwardDirectIssueBillPaperConfig()action. A gear/Settings dialog (privilegeChangeReceiptPrintingPaperTypes,h:selectBooleanCheckboxper format) is wired on the direct-issue, reprint, return and reprint-return pages, followingdeveloper_docs/configuration/printer-configuration-system.md.pharmacy_bill_issue_bht.xhtml,pharmacy_reprint_bill_sale_bht.xhtml,pharmacy_bill_return_bht_issue.xhtml,pharmacy_reprint_bill_return_bht.xhtmlrender the new composites behind the three keys.netValue) on the reprint-sale and reprint-return pages.Safeguards
inward_direct_issue_bill_native_five_five_custom_3,saleBill_Header_Inward_native) are not touched — sale bills are unaffected.departmentPreference.pharmacyBillPaperTypepreview panels are guarded so they don't render alongside the new default format (no double-print).Nursing IP Billing - Show Rate and Value+NursingIPBillingViewRatesgating.Testing
Issue #22035 steps:
Print-format follow-up: compile + XHTML well-formedness verified; end-to-end print verification (A4/FiveFive/POS across issue, reprint, return, reprint-return) pending against a redeployed local instance.
Closes #22035
🤖 Generated with Claude Code