fix(ci): store CLA signatures on an unprotected branch (the CLA gate was unpassable) - #14
Merged
Merged
Conversation
The action commits the signatures file directly, so branch protection on
main rejected it ("Changes must be made through a pull request") and the
action then reported the contributor as unsigned. The CLA gate was
unpassable for every outside contributor.
|
Thank you for your contribution! Before we can merge it, please read our Contributor License Agreement and sign it by posting the following comment: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The CLA gate could not be passed by anyone, including the repo owner. Signing did nothing.
Root cause, from the workflow log:
contributor-assistant/github-actioncommits the signatures file directly to the branch given in itsbranch:input. That was set tomain, which is branch-protected — so the write was rejected, the signature was never persisted, and the action then reported the contributor as unsigned. The bot's PR comment even flipped to "All contributors have signed the CLA ✅" while the check stayed red, because the comment and the persisted state are separate things.Net effect: an outside contributor could sign, be told they'd signed, and still be blocked. For a project actively recruiting contributors that's about as bad as a CI bug gets.
The fix
Point
branch:at a dedicated unprotected branch,cla-signatures(created, verified unprotected). Added a comment beside the setting explaining why it must never bemain, since the failure mode is silent and the error only shows in the action log.Verification
After merge, comment
recheckon any open PR — the action should persist the signature tocla-signaturesand the check should go green. I'll confirm on #13.🤖 Generated with Claude Code